summaryrefslogtreecommitdiff
path: root/buildstream/_artifactcache/artifactcache.py
diff options
context:
space:
mode:
authorSam Thursfield <sam.thursfield@codethink.co.uk>2017-07-13 17:24:01 +0000
committerSam Thursfield <sam.thursfield@codethink.co.uk>2017-07-21 11:17:31 +0100
commit14a8b5aa28db973243b58a9ecb1ac9b26afa0994 (patch)
tree8f992f0d2e54ac3aa74f8a931b39ee0d73f8d63d /buildstream/_artifactcache/artifactcache.py
parent977210795c9ec67309eae3b78e2100c6b2281823 (diff)
downloadbuildstream-sam/artifactcache-preflight-check.tar.gz
Check for write access to remote artifact cache early on in the pipelinesam/artifactcache-preflight-check
Previously, the first time you configured an artifact cache, you would get to the end of your first build and then BuildStream would exit because of some stupid mistake like you got the address slightly wrong or you forgot to add the host keys of the remote artifact cache to `~/.ssh/known_hosts`. To avoid surprises, if there's an artifacts push-url configured we now try to connect to it as a preflight check so that issues are raised early. On success, you will see something like this: [--:--:--][90904fe4][ main:gnu-toolchain/stage2.bst ] START Checking connectivity to remote artifact cache [00:00:00][90904fe4][ main:gnu-toolchain/stage2.bst ] SUCCESS Connectivity OK On failure, it looks like this: [--:--:--][90904fe4][ main:gnu-toolchain/stage2.bst ] START Checking connectivity to remote artifact cache [00:00:03][90904fe4][ main:gnu-toolchain/stage2.bst ] FAILURE BuildStream will be unable to push artifacts to the shared cache: ssh: connect to host ostree.baserock.org port 2220: Connection timed out As a bonus, for some reason this check causes SSH to ask about unknown host keys rather than just failing, so you may now see messages like this if the host keys are unknown rather than an error: The authenticity of host '[ostree.baserock.org]:22200 ([185.43.218.170]:22200)' can't be established. ECDSA key fingerprint is SHA256:mB+MNfYREOdRfp2FG6dceOlguE/Skd4QwnS0tvCPcnI. ECDSA key fingerprint is MD5:8f:fa:ab:90:19:31:f9:f7:f1:d4:e5:f0:a2:be:56:71. Are you sure you want to continue connecting (yes/no)?
Diffstat (limited to 'buildstream/_artifactcache/artifactcache.py')
-rw-r--r--buildstream/_artifactcache/artifactcache.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/buildstream/_artifactcache/artifactcache.py b/buildstream/_artifactcache/artifactcache.py
index 2508e0b88..a7208e8f2 100644
--- a/buildstream/_artifactcache/artifactcache.py
+++ b/buildstream/_artifactcache/artifactcache.py
@@ -28,6 +28,7 @@ from ..exceptions import _ArtifactError
from ..element import _KeyStrength
from .._ostree import OSTreeError
+from .pushreceive import check_push_connection
from .pushreceive import push as push_artifact
from .pushreceive import PushException
@@ -67,6 +68,15 @@ class ArtifactCache():
self.__offline = False
+ def preflight(self):
+ if self.can_push() and not self.context.artifact_push.startswith("/"):
+ try:
+ check_push_connection(self.context.artifact_push,
+ self.context.artifact_push_port)
+ except PushException as e:
+ raise _ArtifactError("BuildStream will be unable to push artifacts "
+ "to the shared cache: {}".format(e))
+
# contains():
#
# Check whether the artifact for the specified Element is already available