diff options
| author | Angelos Evripiotis <jevripiotis@bloomberg.net> | 2019-01-11 17:08:25 +0000 |
|---|---|---|
| committer | Angelos Evripiotis <jevripiotis@bloomberg.net> | 2019-01-29 10:39:29 +0000 |
| commit | 86c8e4146ffd870b71cedf0031881cc4dc998c15 (patch) | |
| tree | 7f36de0d6db55b5f9ca62e22c413638657f883f3 /NEWS | |
| parent | 6a4c86118380d95bdedd11e60f3a771fdae225a3 (diff) | |
| download | buildstream-86c8e4146ffd870b71cedf0031881cc4dc998c15.tar.gz | |
BREAK:remove unconditional 'are you sure?' prompts
This is a breaking change, as it affects behaviour that people might be
relying on. An entry has been added to NEWS.
As proposed on the mailing list, this change removes the unconditional
prompts on:
o: bst workspace reset
o: bst workspace close --remove-dir
If interactive, these commands would always interrupt you with a prompt
like this:
This will remove all your changes, are you sure?
This seems like it may just save someone's work some time. It may also
condition folks to hit 'y' quickly without thinking.
This change also makes the non-interactive behaviour consistent with the
interactive behaviour in the default case. There is also the case of the
prompt configured by 'really-workspace-close-project-inaccessible',
which may be tackled in later work.
This change also removes the new config options to suppress those
prompts, and their associated news entry.
The relevant bit of the mailing list conversation is here:
https://mail.gnome.org/archives/buildstream-list/2018-December/msg00106.html
The issue to make interactive and non-interactive behaviour consistent
is here:
https://gitlab.com/BuildStream/buildstream/issues/744
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 11 |
1 files changed, 5 insertions, 6 deletions
@@ -50,6 +50,11 @@ buildstream 1.3.1 an error message and a hint instead, to avoid bothering folks that just made a mistake. + o BREAKING CHANGE: The unconditional 'Are you sure?' prompts have been + removed. These would always ask you if you were sure when running + 'bst workspace close --remove-dir' or 'bst workspace reset'. They got in + the way too often. + o Failed builds are included in the cache as well. `bst checkout` will provide anything in `%{install-root}`. A build including cached fails will cause any dependant elements @@ -87,12 +92,6 @@ buildstream 1.3.1 instead of just a specially-formatted build-root with a `root` and `scratch` subdirectory. - o The buildstream.conf file learned new - 'prompt.really-workspace-close-remove-dir' and - 'prompt.really-workspace-reset-hard' options. These allow users to suppress - certain confirmation prompts, e.g. double-checking that the user meant to - run the command as typed. - o Due to the element `build tree` being cached in the respective artifact their size in some cases has significantly increased. In *most* cases the build trees are not utilised when building targets, as such by default bst 'pull' & 'build' |