summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJürg Billeter <j@bitron.ch>2018-05-11 10:06:53 +0200
committerJürg Billeter <j@bitron.ch>2018-05-11 10:19:54 +0200
commit3d9491dde89621a52b8f526609bf9647d6e4be23 (patch)
treed399cd891eefeb457e609a66cc363f432de785a4
parent270da0609978ce6d269865b6bd451ec560a983ef (diff)
downloadbuildstream-3d9491dde89621a52b8f526609bf9647d6e4be23.tar.gz
_stream.py: Do not force `PipelineSelection.ALL` for build with tracking
With the dynamic plan using `_set_required()` we can avoid pulling/fetching/building unneeded elements even if elements are being tracked.
-rw-r--r--buildstream/_stream.py2
-rw-r--r--tests/frontend/pull.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/buildstream/_stream.py b/buildstream/_stream.py
index ca999ad6e..cdef69094 100644
--- a/buildstream/_stream.py
+++ b/buildstream/_stream.py
@@ -170,7 +170,7 @@ class Stream():
track_cross_junctions=False,
build_all=False):
- if build_all or track_targets:
+ if build_all:
selection = PipelineSelection.ALL
else:
selection = PipelineSelection.PLAN
diff --git a/tests/frontend/pull.py b/tests/frontend/pull.py
index f73b06876..c3ebe41c7 100644
--- a/tests/frontend/pull.py
+++ b/tests/frontend/pull.py
@@ -273,6 +273,6 @@ def test_push_pull_track_non_strict(cli, tmpdir, datafiles):
# However, pulling has to be deferred until the dependencies have been
# tracked as the strict cache key needs to be calculated before querying
# the caches.
- result = cli.run(project=project, args=['build', '--track-all', 'target.bst'])
+ result = cli.run(project=project, args=['build', '--track-all', '--all', 'target.bst'])
result.assert_success()
assert set(result.get_pulled_elements()) == all_elements