Merge branch 'jonathan/reduce-update-state-calls' into 'master'

Reduce the amount of times we call Element._update_state()

See merge request BuildStream/buildstream!1312

1 files changed, 6 insertions, 2 deletions

diff --git a/buildstream/element.py b/buildstream/element.py
index 05884c008..8cc25fec6 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -1393,7 +1393,6 @@ class Element(Plugin):
     #
     def _schedule_tracking(self):
         self.__tracking_scheduled = True
-        self._update_state()
 
     # _tracking_done():
     #
@@ -1835,7 +1834,12 @@ class Element(Plugin):
     def _fetch_done(self):
         # We are not updating the state recursively here since fetching can
         # never end up in updating them.
-        self._update_state()
+
+        # Fetching changes the source state from RESOLVED to CACHED
+        # Fetching cannot change the source state from INCONSISTENT to CACHED because
+        # we prevent fetching when it's INCONSISTENT.
+        # Therefore, only the source state will change.
+        self.__update_source_state()
 
     # _pull_pending()
     #