summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJürg Billeter <j@bitron.ch>2018-03-15 16:42:27 +0100
committerJürg Billeter <j@bitron.ch>2018-03-15 16:48:07 +0100
commit4b644abac6a81571b3d674c96bf9669f8a86ef8e (patch)
treef9c203c1d461f388ab14acff7ded80ab865fe9b1
parent16ff3374b78b77553f8b01454c1deed8627817cd (diff)
downloadbuildstream-4b644abac6a81571b3d674c96bf9669f8a86ef8e.tar.gz
buildqueue.py: Do not mark assembly complete on build failure
This fixes internal error when build is retried. Fixes #299
-rw-r--r--buildstream/_scheduler/buildqueue.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/buildstream/_scheduler/buildqueue.py b/buildstream/_scheduler/buildqueue.py
index 512fe6c22..53cdb235b 100644
--- a/buildstream/_scheduler/buildqueue.py
+++ b/buildstream/_scheduler/buildqueue.py
@@ -47,9 +47,10 @@ class BuildQueue(Queue):
return QueueStatus.READY
def done(self, element, result, returncode):
- # Inform element in main process that assembly is done
- element._assemble_done()
+ if returncode == 0:
+ # Inform element in main process that assembly is done
+ element._assemble_done()
- element._update_state()
+ element._update_state()
return True