summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-05 17:12:16 +0900
committerTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-05 17:13:35 +0900
commitab63b5364d9035ae46ebba2a2983ffbe3c82c810 (patch)
tree629effd7fb45477a37432939baa1aa305d36391b
parentb8c68284f5bf1fcfd0f826d341088a98ec2e33c1 (diff)
downloadbuildstream-ab63b5364d9035ae46ebba2a2983ffbe3c82c810.tar.gz
_frontend/widget.py: Defend against empty string message detail
It appears we have some cases of empty detail strings that are not None, this was resulting in an IndexError when trying to strip the trailing newline from the message.detail.splitlines() result.
-rw-r--r--buildstream/_frontend/widget.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/buildstream/_frontend/widget.py b/buildstream/_frontend/widget.py
index eaaf1dda8..692510eb0 100644
--- a/buildstream/_frontend/widget.py
+++ b/buildstream/_frontend/widget.py
@@ -395,7 +395,7 @@ class LogLine(Widget):
extra_nl = False
# Now add some custom things
- if message.detail is not None:
+ if message.detail:
# Identify frontend messages, we never abbreviate these
frontend_message = not (message.task_id or message.unique_id)