diff options
| author | Angelos Evripiotis <jevripiotis@bloomberg.net> | 2019-03-01 10:11:17 +0000 |
|---|---|---|
| committer | Angelos Evripiotis <angelos.evripiotis@gmail.com> | 2019-03-01 11:54:54 +0000 |
| commit | 30fedb3aa607c3cefa6505a95c5a1fcf5d616d69 (patch) | |
| tree | 1892f7d8dcdf15a9fe07b9f522e6a3c688984f38 | |
| parent | 57a314d8793b64859598c2217208e2d1d83af5b5 (diff) | |
| download | buildstream-30fedb3aa607c3cefa6505a95c5a1fcf5d616d69.tar.gz | |
buildelement: rm unused 'cmd_name' argument
We're not using the cmd_name parameter to __run_command, and it's
redundant given that the enclosing scope already uses it in the label.
Remove it to slightly improve readability.
| -rw-r--r-- | buildstream/buildelement.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/buildstream/buildelement.py b/buildstream/buildelement.py index 6ef060f12..eb30d9d31 100644 --- a/buildstream/buildelement.py +++ b/buildstream/buildelement.py @@ -239,7 +239,7 @@ class BuildElement(Element): with sandbox.batch(SandboxFlags.ROOT_READ_ONLY, label="Running {}".format(command_name)): for cmd in commands: - self.__run_command(sandbox, cmd, command_name) + self.__run_command(sandbox, cmd) # %{install-root}/%{build-root} should normally not be written # to - if an element later attempts to stage to a location @@ -263,7 +263,7 @@ class BuildElement(Element): if commands: with sandbox.batch(SandboxFlags.ROOT_READ_ONLY, label="Running configure-commands"): for cmd in commands: - self.__run_command(sandbox, cmd, 'configure-commands') + self.__run_command(sandbox, cmd) def generate_script(self): script = "" @@ -288,7 +288,7 @@ class BuildElement(Element): return commands - def __run_command(self, sandbox, cmd, cmd_name): + def __run_command(self, sandbox, cmd): # Note the -e switch to 'sh' means to exit with an error # if any untested command fails. # |