summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-20 14:32:05 +0900
committerTristan Van Berkom <tristan.vanberkom@codethink.co.uk>2018-04-20 14:32:05 +0900
commit61889ed524c9a54e14bd335db871c69abf40f0c2 (patch)
treeb6ab84535a38217011a69491627c162ae030c599
parent78bd7f565f0c86c295f882d662fab2fa39d06cc1 (diff)
downloadbuildstream-61889ed524c9a54e14bd335db871c69abf40f0c2.tar.gz
plugins: Disable attribute-defined-outside-init pylint error
Plugins set their attributes in configure(), because the constructor is not public API.
-rw-r--r--buildstream/plugins/elements/compose.py1
-rw-r--r--buildstream/plugins/elements/filter.py1
-rw-r--r--buildstream/plugins/elements/import.py1
-rw-r--r--buildstream/plugins/elements/junction.py1
-rw-r--r--buildstream/plugins/elements/script.py2
-rw-r--r--buildstream/plugins/sources/_downloadablefilesource.py1
-rw-r--r--buildstream/plugins/sources/bzr.py1
-rw-r--r--buildstream/plugins/sources/deb.py1
-rw-r--r--buildstream/plugins/sources/git.py1
-rw-r--r--buildstream/plugins/sources/local.py1
-rw-r--r--buildstream/plugins/sources/ostree.py1
-rw-r--r--buildstream/plugins/sources/patch.py1
-rw-r--r--buildstream/plugins/sources/tar.py1
-rw-r--r--buildstream/plugins/sources/zip.py1
14 files changed, 15 insertions, 0 deletions
diff --git a/buildstream/plugins/elements/compose.py b/buildstream/plugins/elements/compose.py
index 0fa79336c..370f19dcf 100644
--- a/buildstream/plugins/elements/compose.py
+++ b/buildstream/plugins/elements/compose.py
@@ -40,6 +40,7 @@ from buildstream import Element, Scope
# Element implementation for the 'compose' kind.
class ComposeElement(Element):
+ # pylint: disable=attribute-defined-outside-init
# The compose element's output is it's dependencies, so
# we must rebuild if the dependencies change even when
diff --git a/buildstream/plugins/elements/filter.py b/buildstream/plugins/elements/filter.py
index 2487a9799..1c1a59b76 100644
--- a/buildstream/plugins/elements/filter.py
+++ b/buildstream/plugins/elements/filter.py
@@ -41,6 +41,7 @@ from buildstream import Element, ElementError, Scope
class FilterElement(Element):
+ # pylint: disable=attribute-defined-outside-init
# The filter element's output is it's dependencies, so
# we must rebuild if the dependencies change even when
diff --git a/buildstream/plugins/elements/import.py b/buildstream/plugins/elements/import.py
index dfad178b5..747455d70 100644
--- a/buildstream/plugins/elements/import.py
+++ b/buildstream/plugins/elements/import.py
@@ -37,6 +37,7 @@ from buildstream import Element, BuildElement, ElementError
# Element implementation for the 'import' kind.
class ImportElement(BuildElement):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
self.source = self.node_subst_member(node, 'source')
diff --git a/buildstream/plugins/elements/junction.py b/buildstream/plugins/elements/junction.py
index a512222e0..b3f756380 100644
--- a/buildstream/plugins/elements/junction.py
+++ b/buildstream/plugins/elements/junction.py
@@ -115,6 +115,7 @@ from buildstream._pipeline import PipelineError
# Element implementation for the 'junction' kind.
class JunctionElement(Element):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
self.path = self.node_get_member(node, str, 'path', default='')
diff --git a/buildstream/plugins/elements/script.py b/buildstream/plugins/elements/script.py
index 7769cd120..6778b3fac 100644
--- a/buildstream/plugins/elements/script.py
+++ b/buildstream/plugins/elements/script.py
@@ -40,6 +40,8 @@ import buildstream
# Element implementation for the 'script' kind.
class ScriptElement(buildstream.ScriptElement):
+ # pylint: disable=attribute-defined-outside-init
+
def configure(self, node):
for n in self.node_get_member(node, list, 'layout', []):
dst = self.node_subst_member(n, 'destination')
diff --git a/buildstream/plugins/sources/_downloadablefilesource.py b/buildstream/plugins/sources/_downloadablefilesource.py
index 1f0cf1ef2..1b12efb34 100644
--- a/buildstream/plugins/sources/_downloadablefilesource.py
+++ b/buildstream/plugins/sources/_downloadablefilesource.py
@@ -11,6 +11,7 @@ from buildstream import utils
class DownloadableFileSource(Source):
+ # pylint: disable=attribute-defined-outside-init
COMMON_CONFIG_KEYS = Source.COMMON_CONFIG_KEYS + ['url', 'ref', 'etag']
diff --git a/buildstream/plugins/sources/bzr.py b/buildstream/plugins/sources/bzr.py
index 8c8d0c8c3..3732304fb 100644
--- a/buildstream/plugins/sources/bzr.py
+++ b/buildstream/plugins/sources/bzr.py
@@ -59,6 +59,7 @@ from buildstream import utils
class BzrSource(Source):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
self.node_validate(node, ['url', 'track', 'ref'] + Source.COMMON_CONFIG_KEYS)
diff --git a/buildstream/plugins/sources/deb.py b/buildstream/plugins/sources/deb.py
index 296102d51..ff4321515 100644
--- a/buildstream/plugins/sources/deb.py
+++ b/buildstream/plugins/sources/deb.py
@@ -52,6 +52,7 @@ from .tar import TarSource
class DebSource(TarSource):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
super().configure(node)
diff --git a/buildstream/plugins/sources/git.py b/buildstream/plugins/sources/git.py
index 7ac6dc057..f178656b0 100644
--- a/buildstream/plugins/sources/git.py
+++ b/buildstream/plugins/sources/git.py
@@ -238,6 +238,7 @@ class GitMirror():
class GitSource(Source):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
ref = self.node_get_member(node, str, 'ref', None)
diff --git a/buildstream/plugins/sources/local.py b/buildstream/plugins/sources/local.py
index ebdd86fdf..3193d101d 100644
--- a/buildstream/plugins/sources/local.py
+++ b/buildstream/plugins/sources/local.py
@@ -40,6 +40,7 @@ from buildstream import utils
class LocalSource(Source):
+ # pylint: disable=attribute-defined-outside-init
def __init__(self, context, project, meta):
super().__init__(context, project, meta)
diff --git a/buildstream/plugins/sources/ostree.py b/buildstream/plugins/sources/ostree.py
index bf72fa784..b311e24bf 100644
--- a/buildstream/plugins/sources/ostree.py
+++ b/buildstream/plugins/sources/ostree.py
@@ -58,6 +58,7 @@ from buildstream._ostree import OSTreeError
class OSTreeSource(Source):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
diff --git a/buildstream/plugins/sources/patch.py b/buildstream/plugins/sources/patch.py
index cf9782a80..c9e40b1e6 100644
--- a/buildstream/plugins/sources/patch.py
+++ b/buildstream/plugins/sources/patch.py
@@ -44,6 +44,7 @@ from buildstream import utils
class PatchSource(Source):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
self.path = self.node_get_member(node, str, "path")
diff --git a/buildstream/plugins/sources/tar.py b/buildstream/plugins/sources/tar.py
index cb7dbf69a..e41824505 100644
--- a/buildstream/plugins/sources/tar.py
+++ b/buildstream/plugins/sources/tar.py
@@ -61,6 +61,7 @@ from ._downloadablefilesource import DownloadableFileSource
class TarSource(DownloadableFileSource):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
super().configure(node)
diff --git a/buildstream/plugins/sources/zip.py b/buildstream/plugins/sources/zip.py
index dd7fcd0ad..fdf8947ec 100644
--- a/buildstream/plugins/sources/zip.py
+++ b/buildstream/plugins/sources/zip.py
@@ -60,6 +60,7 @@ from ._downloadablefilesource import DownloadableFileSource
class ZipSource(DownloadableFileSource):
+ # pylint: disable=attribute-defined-outside-init
def configure(self, node):
super().configure(node)