summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbderrahim Kitouni <akitouni@gnome.org>2019-01-27 11:43:18 +0100
committerJavier Jardón <jjardon@gnome.org>2019-02-08 16:42:23 +0000
commit1ee4a4ba3a91e27515967d5e2daaedf664f10c78 (patch)
treea9897453b0311dc8deb0762c432a5ac7349670d7
parent77ce0c1607d060eda098779228d5b0ab62ec04ef (diff)
downloadbuildstream-1ee4a4ba3a91e27515967d5e2daaedf664f10c78.tar.gz
_artifactcache.py: don't leak the project specific remote caches
the code for initializing remotes added the project specific remote caches to the global list instead of making a copy. Fixes #618
-rw-r--r--buildstream/_artifactcache.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/buildstream/_artifactcache.py b/buildstream/_artifactcache.py
index 48ab278c4..de63d30f1 100644
--- a/buildstream/_artifactcache.py
+++ b/buildstream/_artifactcache.py
@@ -467,7 +467,7 @@ class ArtifactCache():
# on_failure (callable): Called if we fail to contact one of the caches.
#
def initialize_remotes(self, *, on_failure=None):
- remote_specs = self.global_remote_specs
+ remote_specs = list(self.global_remote_specs)
for project in self.project_remote_specs:
remote_specs += self.project_remote_specs[project]