diff options
author | Jürg Billeter <j@bitron.ch> | 2018-01-18 12:12:48 +0100 |
---|---|---|
committer | Jürg Billeter <j@bitron.ch> | 2018-01-18 12:24:57 +0100 |
commit | f490343d98e40f9c9b651aa02f351d0bbee9afd9 (patch) | |
tree | 9f4a0677c1854dd6627fbba622677d9b3e2c5c79 | |
parent | d759994ecb196b497c090fbf4d3be9642696b087 (diff) | |
download | buildstream-f490343d98e40f9c9b651aa02f351d0bbee9afd9.tar.gz |
element.py: Return all refs in _track()
TrackQueue must call _set_ref() for all sources, otherwise the source
will never get out of the inconsistent state. This fixes --track when
using local sources.
Fixes: 03412a9e ("Use explicit source state updates")
-rw-r--r-- | buildstream/element.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/buildstream/element.py b/buildstream/element.py index c7b13232e..15a4f043b 100644 --- a/buildstream/element.py +++ b/buildstream/element.py @@ -967,13 +967,12 @@ class Element(Plugin): # (list): A list of Source object ids and their new references # def _track(self): - changed = [] + refs = [] for source in self.__sources: new_ref = source._track() - if new_ref is not None: - changed.append((source._get_unique_id(), new_ref)) + refs.append((source._get_unique_id(), new_ref)) - return changed + return refs # _assemble(): # |