_yaml: Ensure every element passed to list_copy or node_set is a Node

This is to restrict the API to always work with nodes in order to
sanitize the API

1 files changed, 6 insertions, 4 deletions

diff --git a/src/buildstream/_yaml.pyx b/src/buildstream/_yaml.pyx
index c565fe12e..4e0659f40 100644
--- a/src/buildstream/_yaml.pyx
+++ b/src/buildstream/_yaml.pyx
@@ -624,6 +624,9 @@ cdef list __trim_list_provenance(list value):
 cpdef void node_set(Node node, object key, object value, list indices=None) except *:
     cdef int idx
 
+    if type(value) is list:
+        value = __new_node_from_list(value)
+
     if indices:
         node = <Node> (<dict> node.value)[key]
         key = indices.pop()
@@ -1176,11 +1179,10 @@ cpdef Node node_copy(Node source):
 # Internal function to help node_copy() but for lists.
 cdef Node _list_copy(Node source):
     cdef list copy = []
+    cdef Node item
+
     for item in source.value:
-        if type(item) is Node:
-            item_type = type(item.value)
-        else:
-            item_type = type(item)
+        item_type = type(item.value)
 
         if item_type is dict:
             copy.append(node_copy(item))