Prevent caching when Element.stage() failsgokcennurlu/dont_cache_if_stage_fails

That step is not actually part of the build phase should not be cached and
causes hard to find bugs.

Fixes #791

1 files changed, 5 insertions, 5 deletions

diff --git a/buildstream/element.py b/buildstream/element.py
index 8fc491204..ac1dec4ac 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -1620,12 +1620,12 @@ class Element(Plugin):
                 self.__dynamic_public = _yaml.node_copy(self.__public)
 
                 # Call the abstract plugin methods
-                try:
-                    # Step 1 - Configure
-                    self.__configure_sandbox(sandbox)
-                    # Step 2 - Stage
-                    self.stage(sandbox)
 
+                # Step 1 - Configure
+                self.__configure_sandbox(sandbox)
+                # Step 2 - Stage
+                self.stage(sandbox)
+                try:
                     if self.__batch_prepare_assemble:
                         cm = sandbox.batch(self.__batch_prepare_assemble_flags,
                                            collect=self.__batch_prepare_assemble_collect)