summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Schubert <contact@benschubert.me>2019-07-15 22:22:54 +0100
committerBenjamin Schubert <contact@benschubert.me>2019-07-15 22:22:54 +0100
commit1ed1642610afea2acd707e79c992a631caad9c90 (patch)
treed8167c5bd6c28397165cb40cab925c2c9fb5d6a3
parent12c919a4bb3f8b1383d2e34709739a82874e34ba (diff)
downloadbuildstream-bschubert/hotfix.tar.gz
variables: fix checking for missing with provenancebschubert/hotfix
A bug was introduced with the new Node API, where provenance only works on node. This fixes it
-rw-r--r--src/buildstream/_variables.pyx2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/buildstream/_variables.pyx b/src/buildstream/_variables.pyx
index 470feddc9..8f91c9ced 100644
--- a/src/buildstream/_variables.pyx
+++ b/src/buildstream/_variables.pyx
@@ -139,7 +139,7 @@ cdef class Variables:
for var in expstr[1::2]:
if var not in self._expstr_map:
line = " unresolved variable '{unmatched}' in declaration of '{variable}' at: {provenance}"
- provenance = expstr.get_provenance()
+ provenance = self.original.get_scalar(key).get_provenance()
summary.append(line.format(unmatched=var, variable=key, provenance=provenance))
if summary:
raise LoadError(LoadErrorReason.UNRESOLVED_VARIABLE,