diff options
| author | Angelos Evripiotis <jevripiotis@bloomberg.net> | 2018-11-07 10:08:05 +0000 |
|---|---|---|
| committer | Angelos Evripiotis <angelos.evripiotis@gmail.com> | 2018-11-08 15:49:16 +0000 |
| commit | c0a8bb664fe2165c6a94b95f337c6f75f9e14362 (patch) | |
| tree | fd6644127262c5a6d8b32a817878352d0104d2f2 | |
| parent | e578a89ffee0ffa7201fa41fffcbc5468791ce6c (diff) | |
| download | buildstream-c0a8bb664fe2165c6a94b95f337c6f75f9e14362.tar.gz | |
contributing: WIP again to be kind to reviewers
As someone coming from GitHub to GitLab, I was pleasantly surprised by
the 'filter by WIP status' option.
To make sure we get the most out of it, add a guideline to keep the
filter clean, to reduce reviewer burden.
| -rw-r--r-- | CONTRIBUTING.rst | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 0f872e9e1..8d4abf979 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -97,7 +97,13 @@ a new merge request. You can also `create a merge request for an existing branch You may open merge requests for the branches you create before you are ready to have them reviewed and considered for inclusion if you like. Until your merge request is ready for review, the merge request title must be prefixed with the -``WIP:`` identifier. +``WIP:`` identifier. GitLab `treats this specially +<https://docs.gitlab.com/ee/user/project/merge_requests/work_in_progress_merge_requests.html>`_, +which helps reviewers. + +Consider marking a merge request as WIP again if you are taking a while to +address a review point. This signals that the next action is on you, and it +won't appear in a reviewer's search for non-WIP merge requests to review. Organized commits |