summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTristan Van Berkom <tristan.van.berkom@gmail.com>2018-07-30 13:11:34 +0000
committerTristan Van Berkom <tristan.van.berkom@gmail.com>2018-07-30 13:11:34 +0000
commitae47a72bf5316b1e49b3ea325f2a978bf07eccac (patch)
tree75c0c98d9fac4d97d6a90930e041e4e7370f1fe2
parent4a3def5c6fe4c9da7f97c2c4ef61d8b6151f19e4 (diff)
parent34015a265f5afa52b14e41634959edcddbbd15d4 (diff)
downloadbuildstream-ae47a72bf5316b1e49b3ea325f2a978bf07eccac.tar.gz
Merge branch 'tlater/ask-for-dev-permissions' into 'master'
HACKING.rst: Add note about asking for dev permissions See merge request BuildStream/buildstream!587
-rw-r--r--HACKING.rst5
1 files changed, 5 insertions, 0 deletions
diff --git a/HACKING.rst b/HACKING.rst
index 5786afdb3..67797d6eb 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -23,6 +23,11 @@ a reasonable timeframe for identifying these.
Patch submissions
-----------------
+If you want to submit a patch, do ask for developer permissions on our
+IRC channel first (GitLab's button also works, but you may need to
+shout about it - we often overlook this) - for CI reasons, it's much
+easier if patches are in branches of the main repository.
+
Branches must be submitted as merge requests in gitlab. If the branch
fixes an issue or is related to any issues, these issues must be mentioned
in the merge request or preferably the commit messages themselves.