diff options
| author | Tristan Van Berkom <tristan.vanberkom@codethink.co.uk> | 2018-07-18 20:50:33 +0900 |
|---|---|---|
| committer | Tristan Van Berkom <tristan.vanberkom@codethink.co.uk> | 2018-07-18 20:52:43 +0900 |
| commit | 26b9f6fae96c1a5cf1abee43a5bf79c3591319b0 (patch) | |
| tree | 6938ca57ae0de86fe2f6cb367acbf4caed0bc7e8 | |
| parent | d835c37f2514767b64f6fa5eee0821ec1943a7fd (diff) | |
| download | buildstream-26b9f6fae96c1a5cf1abee43a5bf79c3591319b0.tar.gz | |
_stream.py: Clarifying ambiguous FIXME comment about required artifactsbst-1-branchpoint
| -rw-r--r-- | buildstream/_stream.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/buildstream/_stream.py b/buildstream/_stream.py index 34baa0b05..646b7a27c 100644 --- a/buildstream/_stream.py +++ b/buildstream/_stream.py @@ -879,9 +879,12 @@ class Stream(): # Set the "required" artifacts that should not be removed # while this pipeline is active # - # FIXME: The set of required artifacts should probably be - # what's in `selected`, but this does not seem to work - # for some reason + # FIXME: The set of required artifacts is only really needed + # for build and pull tasks. + # + # It must include all the artifacts which are required by the + # final product. Note that this is a superset of the build plan. + # self._artifacts.append_required_artifacts((e for e in self._pipeline.dependencies(elements, Scope.ALL))) if selection == PipelineSelection.PLAN and dynamic_plan: |