summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add -l option to src-release script.Nick Clifton2017-09-152-2/+28
| | | | | | | | | | | | | | Since we are updating src-release.sh I thought I would check in this small patch. It adds the option to create lzip compressed tarballs via the -l command line option. * src-release.sh (LZIPPROG): New define. Provides the name of the lzip program. (do_lz): New function. Compresses a tarball using the lzip program. (do_compress): Add support for lzip compression. (usage): Mention -l option. (build_release): Support -l option to invoke lzip compression.
* linux-low: Remove unused variablesSimon Marchi2017-09-152-1/+5
| | | | | | | gdb/gdbserver/ChangeLog: * linux-low.c (linux_set_resume_request): Remove unused variables.
* dwarf2read: Replace copy_string usages with savestringSimon Marchi2017-09-152-17/+8
| | | | | | | | | | copy_string does the exact same thing as savestring, so replace the usages of the former with the latter. gdb/ChangeLog: * dwarf2read.c (copy_string): Remove. (parse_macro_definition): Replace copy_string with savestring.
* gdbserver: Remove duplicate functions to find any thread of processSimon Marchi2017-09-156-70/+24
| | | | | | | | | | | | | | | | | | | | | | | | We have about 6 functions/callbacks to find_inferior meant to find a thread that belongs to a given pid. Remove all but find_any_thread_of_pid and replace their uses with find_any_thread_of_pid. gdb/gdbserver/ChangeLog: * server.c (first_thread_of): Remove. (process_serial_event): Replace usage of first_thread_of with find_any_thread_of_pid. * tracepoint.c (same_process_p): Remove. (gdb_agent_about_to_close): Replace usage of same_process_p with find_any_thread_of_pid. * linux-x86-low.c (same_process_callback): Remove. (x86_arch_setup_process_callback): Replace usage of same_process_callback with find_any_thread_of_pid. * thread-db.c (any_thread_of): Remove. (switch_to_process): Replace usage of any_thread_of with find_any_thread_of_pid. * inferiors.c (thread_pid_matches_callback): Remove. (find_thread_process): Adjust to use find_any_thread_of_pid.
* Fix x86 build failuresYao Qi2017-09-152-3/+11
| | | | | | | | | | | | | | | | | Christophe Lyon told me that GDB build failed on i386-linux with --enable-64-bit-bfd=yes, so I audit the gdb/configure.tgt again. I find that i386-darwin has the same issue too. Additionally, GDB for solaris target fails to build too. This patch fixes all of them. gdb: 2017-09-15 Yao Qi <yao.qi@linaro.org> * configure.tgt (i[34567]86-*-darwin*): Append amd64.o to gdb_target_obs. (i[34567]86-*-solaris2.1[0-9]* | x86_64-*-solaris2.1[0-9]*): Likewise. (i[34567]86-*-linux*): Likewise.
* PR22118, Incorrectly-capitalized regexpAlan Modra2017-09-152-1/+6
| | | | | PR 22118 * testsuite/ld-aarch64/erratum843419.d: Correct regexp.
* Enable/disable various dirs in src-release.shAlan Modra2017-09-152-2/+18
| | | | | | | | | | gold needs to be enabled for a binutils release, but it's rather odd to do so for gas, gdb or sim. This patch passes various --enable and --disable options depending on the directories being released. * src-release.sh (do_proto_toplev): Revert last patch. Enable or disable binutils, gas, gdb, gold, gprof, ld, libdecnumber, readline, and sim depending on $tool and $support_files. Echo configure line.
* Error when 32-bit ar tries to handle 4G or larger filesAlan Modra2017-09-152-0/+12
| | | | | | | | | | | | We used to silently truncate the size returned by stat() to 32 bits. While it is possible to make binutils handle a 64-bit off_t on a 32-bit host, to me the effort needed doesn't seem worth the benefit. Instead, error if we truncate the size. I've written the test the way I have to avoid a signed/unsigned warning. PR 22116 * archive.c (bfd_ar_hdr_from_filesystem): Detect when status.st_size overflows bfd_size_type.
* Automatic date update in version.inGDB Administrator2017-09-151-1/+1
|
* Make dwarf_expr_context::stack an std::vectorSimon Marchi2017-09-143-78/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the manually managed array with a vector. It is mostly straightforward, except maybe one thing in execute_stack_op, in the handling of DW_OP_fbreg. When the code stumbles on that opcode while evaluating an expression, it needs to evaluate a subexpression to find where the fb reg has been saved. Rather than creating a new context, it reuses the current context. It saves the size of the stack before and restores the stack to that size after. I think we can do a little bit better by saving the current stack locally and installing a new empty stack. This way, if the subexpression is malformed and underflows, we'll get an exception. Before, it would have overwritten the top elements of the top-level expression. The evaluation of the top-level expression would have then resumed with the same stack size, but possibly some corrupted elements. gdb/ChangeLog: * dwarf2expr.h (dwarf_stack_value): Add constructor. (dwarf_expr_context) <~dwarf_expr_context>: Define as default. <stack>: Change type to std::vector. <stack_len, stack_allocated>: Remove. <grow_stack>: Remove. * dwarf2expr.c (dwarf_expr_context::dwarf_expr_context): Adjust. (dwarf_expr_context::~dwarf_expr_context): Remove. (dwarf_expr_context::grow_stack): Remove. (dwarf_expr_context::push): Adjust. (dwarf_expr_context::pop): Adjust. (dwarf_expr_context::fetch): Adjust. (dwarf_expr_context::fetch_in_stack_memory): Adjust. (dwarf_expr_context::stack_empty_p): Adjust. (dwarf_expr_context::execute_stack_op): Adjust.
* globalaudit.rd: Allow additional bits in DT_FLAGS_1H.J. Lu2017-09-142-1/+7
| | | | | | | | | | | | With -PIE on x86-64, we get 0x000000006ffffffb (FLAGS_1) Flags: GLOBAUDIT PIE We should allow additional bits in DT_FLAGS_1. PR ld/22139 * testsuite/ld-elf/globalaudit.rd: Allow additional bits in DT_FLAGS_1.
* x86: Cache section contents and relocationsH.J. Lu2017-09-1410-5/+96
| | | | | | | | | | | | | | | | | | | | | | bfd/ PR ld/22135 * elf32-i386.c (elf_i386_convert_load_reloc): Add an argument to indicate if conversion is performed. (elf_i386_check_relocs): Cache section contents and relocations if conversion is performed. * elf64-x86-64.c (elf_x86_64_check_relocs): Cache section contents and relocations if conversion is performed. ld/ PR ld/22135 * testsuite/ld-i386/i386.exp: Run pr22135. * testsuite/ld-x86-64/x86-64.exp: Likewise. * testsuite/ld-i386/pr22135.d: New file. * testsuite/ld-i386/pr22135.s: Likewise. * testsuite/ld-x86-64/pr22135.d: Likewise. * testsuite/ld-x86-64/pr22135.s: Likewise.
* gdb.base/nodebug.exp: Rename called functionsPedro Alves2017-09-142-2/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | I'm seeing these failures on my system: FAIL: gdb.base/nodebug.exp: p (double) mult (2.0, 3.0) FAIL: gdb.base/nodebug.exp: p ((double (*) (double, double)) mult)(2.0f, 3.0f) FAIL: gdb.base/nodebug.exp: p ((double (*) (double, double)) mult)(2, 3) The problem is simply that GDB is finding a symbol named "mult" from glibc's debug info: (gdb) ptype mult type = enum expression_operator {var, num, lnot, mult, divide, module, plus, minus, less_than, greater_than, less_or_equal, greater_or_equal, equal, not_equal, land, lor, qmop} (gdb) info types expression_operator All types matching regular expression "expression_operator": File plural-exp.h: enum expression_operator; Fix this by unloading symbols from shared libraries. gdb/testsuite/ChangeLog: 2017-09-14 Pedro Alves <palves@redhat.com> * gdb.base/nodebug.exp (nodebug_runto): New procedure. (top level): Use it instead of runto.
* Make dwarf_expr_context::stack_empty_p return a boolSimon Marchi2017-09-143-2/+8
| | | | | | | | gdb/ChangeLog: * dwarf2expr.h (dwarf_expr_context) <stack_empty_p>: Change return type to bool. * dwarf2expr.c (dwarf_expr_context::stack_empty_p): Likewise.
* Make dwarf_stack_value::in_stack_memory a boolSimon Marchi2017-09-144-19/+35
| | | | | | | | | | | | | | | | | | | | | Replace int with bool, because that's what it is. gdb/ChangeLog: * dwarf2expr.h (dwarf_expr_piece) <v.mem.in_stack_memory>: Change type to bool. (dwarf_stack_value) <in_stack_memory>: Likewise. (dwarf_expr_context) <push_address>: Change parameter type to bool. <fetch_in_stack_memory>: Change return type to bool. <push>: Change parameter type to bool. * dwarf2expr.c (dwarf_expr_context::push): Change parameter type to bool. (dwarf_expr_context::push_address): Likewise. (dwarf_expr_context::fetch_in_stack_memory): Change return type to bool. (dwarf_expr_context::execute_stack_op): Adjust. * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Adjust.
* Make dwarf_expr_piece::pieces an std::vectorSimon Marchi2017-09-144-124/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the manually managed array dwarf_expr_piece::piece with an std::vector. After passing the pieces array to allocate_piece_closure, dwarf2_evaluate_loc_desc_full doesn't need that data anymore. We can therefore move the content of the vector to avoid copying it. Reg-tested on the buildbot. gdb/ChangeLog: * dwarf2expr.h (struct dwarf_expr_piece): Move up. (struct dwarf_expr_context) <n_pieces>: Remove. <pieces>: Change type to std::vector. * dwarf2expr.c (dwarf_expr_context::dwarf_expr_context): Adjust. (dwarf_expr_context::~dwarf_expr_context): Don't manually free pieces. (dwarf_expr_context::add_piece): Adjust. * dwarf2loc.c (struct piece_closure): Initialize fields. <n_pieces>: Remove. <pieces>: Change type to std::vector. (allocate_piece_closure): Adjust, change parameter to std::vector rvalue and std::move it to piece_closure. (rw_pieced_value): Adjust. (check_pieced_synthetic_pointer): Adjust. (indirect_synthetic_pointer): Adjust. (coerce_pieced_ref): Adjust. (free_pieced_value_closure): Adjust. Use delete to free piece_closure. (dwarf2_evaluate_loc_desc_full): Adjust. std::move ctx.pieces to allocate_piece_closure. (dwarf2_loc_desc_get_symbol_read_needs): Adjust.
* Fix address violation when parsing a corrupt PE binary.Nick Clifton2017-09-142-2/+9
| | | | | | PR binutils/22113 * peXXigen.c (pe_print_idata): Extend check for HintName vector entries.
* Add enable-gold and enable-ld to src-releasematt rice2017-09-142-1/+5
| | | | | | So that the tarball picks up gold bison output. * src-release.sh (do_proto_toplev): Enable gold during release process.
* PR22127, as segfaults assembling invalid .relocAlan Modra2017-09-142-1/+7
| | | | | | | | | | | | "sec" gets set to NULL on errors in the offset expression. This patch disables part of the reloc expression processing that needs "sec" valid. I didn't disable the entire reloc expression handling so that errors in the reloc expression are reported even when the offset expression has an error. PR 22127 * write.c (resolve_reloc_expr_symbols): Don't segfault when sec has been set to NULL.
* Automatic date update in version.inGDB Administrator2017-09-141-1/+1
|
* elfxx-x86.h: Fix a typo in commentsH.J. Lu2017-09-132-1/+5
| | | | * elfxx-x86.h: Fix a typo in comments.
* Automatic date update in version.inGDB Administrator2017-09-131-1/+1
|
* probe: Replace VEC(probe_ops_cp) with std::vectorSimon Marchi2017-09-126-31/+26
| | | | | | | | | | | | | | | | | | | | This patch replaces the usage of VEC to store pointers to probe_ops with an std::vector. The sole usage of that vector type is one global variable that holds the ops for the various kinds of probes, so this is pretty straightforward (no allocation/deallocation issues). gdb/ChangeLog: * probe.h (probe_ops_cp): Remove typedef. (DEF_VEC_P (probe_ops_cp)): Remove. (all_probe_ops): Change type to std::vector. * probe.c (info_probes_for_ops): Adjust to vector change. (probe_linespec_to_ops): Likewise. (all_probe_ops): Change type to std::vector. (_initialize_probe): Adjust to vector change. * dtrace-probe.c (_initialize_dtrace_probe): Likewise. * elfread.c (elf_get_probes): Likewise. * stap-probe.c (_initialize_stap_probe): Likewise.
* Make collect_probes return an std::vectorSimon Marchi2017-09-123-94/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change collect_probes so it returns an std::vector<bound_probe> instead of a VEC(bound_probe_s). This allows removing some cleanups. It also seems like enable_probes_command and disable_probes_command were not freeing that vector. The comparison function compare_probes needs to be updated to return a bool indicating whether the first parameter is "less than" the second parameter. I defined two constructors to bound_probe. The default constructor is needed, for example, so the instance in struct bp_location can be constructed without parameters. The constructor with parameters is useful so we can use emplace_back and pass the values directly. The s390 builder on the buildbot shows a weird failure that I can't explain: ../../binutils-gdb/gdb/elfread.c: In function void probe_key_free(bfd*, void*): ../../binutils-gdb/gdb/elfread.c:1346:8: error: types may not be defined in a for-range-declaration [-Werror] for (struct probe *probe : *probes) ^~~~~~ I guess it's a bug with that specific version< of the compiler, since no other gcc gives me that error. It is using: g++ (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1) Any idea about this problem? gdb/ChangeLog: * probe.h (struct bound_probe): Define constructors. * probe.c (bound_probe_s): Remove typedef. (DEF_VEC_O (bound_probe_s)): Remove VEC. (collect_probes): Change return type to std::vector, remove cleanup. (compare_probes): Return bool, change parameter type. Change semantic to "less than". (gen_ui_out_table_header_info): Change parameter to std::vector and update. (exists_probe_with_pops): Likewise. (info_probes_for_ops): Update to std::vector change. (enable_probes_command): Likewise. (disable_probes_command): Likewise.
* Make probe_ops::get_probes fill an std::vectorSimon Marchi2017-09-128-60/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch changes one usage of VEC to std::vector. It is a relatively straightforward 1:1 change. The implementations of sym_probe_fns::sym_get_probes return a borrowed reference to their probe vectors, meaning that the caller should not free it. In the new code, I made them return a const reference to the vector. This patch and the following one were tested by the buildbot. I didn't see any failures that looked related to this one. gdb/ChangeLog: * probe.h (struct probe_ops) <get_probes>: Change parameter from vec to std::vector. * probe.c (parse_probes_in_pspace): Update. (find_probes_in_objfile): Update. (find_probe_by_pc): Update. (collect_probes): Update. (probe_any_get_probes): Update. * symfile.h (struct sym_probe_fns) <sym_get_probes> Change return type to reference to std::vector. * dtrace-probe.c (dtrace_process_dof_probe): Change parameter to std::vector and update. (dtrace_process_dof): Likewise. (dtrace_get_probes): Likewise. * elfread.c (elf_get_probes): Change return type to std::vector, store an std::vector in bfd_data. (probe_key_free): Update to std::vector. * stap-probe.c (handle_stap_probe): Change parameter to std::vector and update. (stap_get_probes): Likewise. * symfile-debug.c (debug_sym_get_probes): Change return type to std::vector and update.
* Automatic date update in version.inGDB Administrator2017-09-121-1/+1
|
* Remove make_show_memory_breakpoints_cleanupTom Tromey2017-09-117-58/+46
| | | | | | | | | | | | | | | | | | | | | This removes make_show_memory_breakpoints_cleanup, replacing it with make_scoped_restore_show_memory_breakpoints and updating all callers. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * breakpoint.c (program_breakpoint_here_p): Update. * target.c (make_scoped_restore_show_memory_breakpoints): Rename from make_show_memory_breakpoints_cleanup. Return a scoped_restore_tmpl<int>. (restore_show_memory_breakpoints): Remove. * ppc-linux-tdep.c (ppc_linux_memory_remove_breakpoint): Update. * mem-break.c (memory_validate_breakpoint): Update. * ia64-tdep.c (ia64_memory_insert_breakpoint): Update. (ia64_memory_remove_breakpoint): Update. (ia64_breakpoint_from_pc): Update. * target.h (make_scoped_restore_show_memory_breakpoints): Rename from make_show_memory_breakpoints_cleanup.
* Use std::string in d-namespace.cTom Tromey2017-09-112-33/+17
| | | | | | | | | | | This removes some cleanups from d-namespace.c by replacing manual string management with std::string. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * d-namespace.c (d_lookup_symbol): Use std::string. (find_symbol_in_baseclass): Likewise.
* Use std::string in ctf_startTom Tromey2017-09-112-12/+10
| | | | | | | | | | This changes ctf_start to use std::string, allowing for some cleanup removal. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * ctf.c (ctf_start): Use std::string.
* Remove cleanups from find_frame_funnameTom Tromey2017-09-116-55/+49
| | | | | | | | | | | | | | | | | This changes find_frame_funname to return a unique_xmalloc_ptr and then fixes up the callers. This removes several cleanups. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * ada-lang.c (is_known_support_routine): Update. (ada_unhandled_exception_name_addr_from_raise): Update. * guile/scm-frame.c (gdbscm_frame_name): Update. * python/py-frame.c (frapy_name): Update. (frapy_function): Update. * stack.h (find_frame_funname): Update. * stack.c (find_frame_funname): Return unique_xmalloc_ptr. (print_frame): Update.
* Remove cleanups from findcmd.cTom Tromey2017-09-112-64/+35
| | | | | | | | | | | | | | This removes cleanups from findcmd.c, replacing manual buffer management with a gdb::byte_vector. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * findcmd.c (put_bits): Take a gdb::byte_vector. (parse_find_args): Return gdb::byte_vector. "args" now const. Remove "pattern_bufp" and "pattern_lenp" parameters. Remove cleanups. (find_command): Update.
* Replace clear_hook_in_cleanup with scoped_restore_hook_inTom Tromey2017-09-112-10/+28
| | | | | | | | | | | | | | This removes clear_hook_in_cleanup in favor of a scoped_restore-like class. scoped_restore itself can't be used because hook_in is a bitfield. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * cli/cli-script.c (class scoped_restore_hook_in): New. (clear_hook_in_cleanup): Remove. (execute_cmd_pre_hook, execute_cmd_post_hook): Use scoped_restore_hook_in.
* Replace interp_set_temp with scoped_restore_interpTom Tromey2017-09-114-10/+37
| | | | | | | | | | | | | | | This removes interp_set_temp and an associated cleanup, in favor of a new RAII class, scoped_restore_interp. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * cli/cli-script.c (restore_interp): Remove. (read_command_lines): Use scoped_restore_interp. * interps.c (scoped_restore_interp::set_temp): Rename from interp_set_temp. * interps.h (class scoped_restore_interp): New. (interp_set_temp): Remove.
* Change setup_breakpoint_reporting to return a scoped_restoreTom Tromey2017-09-114-17/+20
| | | | | | | | | | | | | | | | This changes setup_breakpoint_reporting to return a scoped_restore, allowing for some cleanup removal. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * mi/mi-cmd-catch.c (mi_cmd_catch_assert) (mi_cmd_catch_exception, mi_catch_load_unload): Update. * mi/mi-cmd-break.c (setup_breakpoint_reporting): Return a scoped_restore. (mi_cmd_break_insert_1): Update. * mi/mi-cmd-break.h (setup_breakpoint_reporting): Return a scoped_restore.
* Make extract_arg return a std::stringTom Tromey2017-09-1110-85/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change extract_arg to return a std::string and fix up all the users. I think string is mildly better than unique_xmalloc_ptr<char>, when possible, because it provides a more robust API. I changed the error messages emitted from find_location_by_number to avoid either writing to a string or an extra allocation; this can be changed but I thought that the new message was not any less clear. You can see an example in the testsuite patch. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * demangle.c (demangle_command): Update. * breakpoint.c (disable_command): Update. (enable_command): Update. (find_location_by_number): Make "number" const. Use get_number_trailer. * cli/cli-utils.c (extract_arg): Return std::string. * probe.c (parse_probe_linespec): Update. Change types. (collect_probes): Take string arguments. (parse_probe_linespec): Likewise. (info_probes_for_ops): Update. (enable_probes_command): Update. (disable_probes_command): Update. * break-catch-sig.c (catch_signal_split_args): Update. * mi/mi-parse.c (mi_parse): Update. testsuite/ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * gdb.base/ena-dis-br.exp (test_ena_dis_br): Update test.
* Constify language_enumTom Tromey2017-09-113-2/+7
| | | | | | | | | | Change language_enum to take a const argument. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * language.h (language_enum): Make argument const. * language.c (language_enum): Make argument const.
* Rename _const functions to use overloading insteadTom Tromey2017-09-1137-125/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This renames a few functions -- skip_spaces_const, skip_to_space_const, get_number_const, extract_arg_const -- to drop the "_const" suffix and instead rely on overloading. This makes future const fixes simpler by reducing the number of lines that must be changed. I think it is also not any less clear, as all these functions have the same interface as their non-const versions by design. Furthermore there's an example of using an overload in-tree already, namely check_for_argument. This patch was largely created using some perl one-liners; then a few fixes were applied by hand. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * common/common-utils.h (skip_to_space): Remove macro, redeclare as function. (skip_to_space): Rename from skip_to_space_const. * common/common-utils.c (skip_to_space): New function. (skip_to_space): Rename from skip_to_space_const. * cli/cli-utils.h (get_number): Rename from get_number_const. (extract_arg): Rename from extract_arg_const. * cli/cli-utils.c (get_number): Rename from get_number_const. (extract_arg): Rename from extract_arg_const. (number_or_range_parser::get_number): Use ::get_number. * aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c, break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c, cli/cli-script.c, cli/cli-setshow.c, compile/compile.c, completer.c, demangle.c, disasm.c, findcmd.c, linespec.c, linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c, minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c, python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c, stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
* Make it simpler to add events to PythonTom Tromey2017-09-1117-303/+250
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first patch in this series went through several iterations as I'd forgotten how many places had to be touched to add a new event and a new event type. This patch simplifies the process using two new ".def" files. Now, a new event type can be added by adding a line to "py-event-types.def", and a new event registry can be added by adding a line to "py-all-events.def". ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * python/python.c (do_start_initialization): Use py-event-types.def to initialize types. Define all object type structures. * python/python-internal.h: Don't declare event initialization functions. * python/py-threadevent.c (thread_event_object_type): Don't define. * python/py-stopevent.c (stop_event_object_type): Don't define. * python/py-signalevent.c (signal_event_object_type): Don't declare or define. * python/py-newobjfileevent.c (new_objfile_event_object_type) (clear_objfiles_event_object_type): Don't declare or define. * python/py-infevents.c (inferior_call_pre_event_object_type) (inferior_call_post_event_object_type) (register_changed_event_object_type) (memory_changed_event_object_type): Don't declare or define. * python/py-inferior.c (new_thread_event_object_type) (new_inferior_event_object_type) (inferior_deleted_event_object_type): Don't declare or define. * python/py-exitedevent.c (exited_event_object_type): Don't declare or define. * python/py-evts.c (gdbpy_initialize_py_events): Use py-all-events.def. * python/py-events.h (thread_event_object_type): Don't declare. (events_object): Use py-all-events.def. * python/py-event.h (GDBPY_NEW_EVENT_TYPE): Remove. Use py-event-types.def. * python/py-event-types.def: New file. * python/py-continueevent.c (create_continue_event_object): Don't declare or define. * python/py-bpevent.c (breakpoint_event_object_type): Don't declare or define. * python/py-all-events.def: New file.
* Small event ownership clean up in Python layerTom Tromey2017-09-1110-23/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems cleaner to me for functions like create_thread_event_object, which pass object ownership to their callers, to directly return a gdb_ref<>. This way the ownership transfer is part of the API. This patch makes this change. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * python/py-threadevent.c (create_thread_event_object): Return gdbpy_ref. * python/py-stopevent.h (create_stop_event_object) (create_breakpoint_event_object, create_signal_event_object): Update. * python/py-stopevent.c (create_stop_event_object): Return gdbpy_ref. (emit_stop_event): Update. * python/py-signalevent.c (create_signal_event_object): Return gdbpy_ref. * python/py-infevents.c (create_inferior_call_event_object): Update. * python/py-event.h (create_event_object) (create_thread_event_object): Update. * python/py-event.c (create_event_object): Return gdbpy_ref. * python/py-continueevent.c: Return gdbpy_ref. * python/py-bpevent.c (create_breakpoint_event_object): Return gdbpy_ref.
* Add new_inferior, inferior_deleted, and new_thread eventsTom Tromey2017-09-1114-7/+229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a few new events to gdb's Python layer: new_inferior, inferior_deleted, and new_thread. I wanted to be able to add a combined inferior/thread display window to my GUI, and I needed a few events to make this work. This is PR python/15622. ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> PR python/15622: * NEWS: Add entry. * python/python.c (do_start_initialization): Initialize new event types. * python/python-internal.h (gdbpy_initialize_new_inferior_event) (gdbpy_initialize_inferior_deleted_event) (gdbpy_initialize_new_thread_event): Declare. * python/py-threadevent.c (create_thread_event_object): Add option "thread" parameter. * python/py-inferior.c (new_thread_event_object_type) (new_inferior_event_object_type) (inferior_deleted_event_object_type): Declare. (python_new_inferior, python_inferior_deleted): New functions. (add_thread_object): Emit new_thread event. (gdbpy_initialize_inferior): Attach new functions to corresponding observers. (new_thread, new_inferior, inferior_deleted): Define new event types. * python/py-evts.c (gdbpy_initialize_py_events): Add new registries. * python/py-events.h (events_object) <new_inferior, inferior_deleted, new_thread>: New fields. * python/py-event.h (create_thread_event_breakpoint): Add optional "thread" parameter. doc/ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * python.texi (Events In Python): Document new events. testsuite/ChangeLog 2017-09-11 Tom Tromey <tom@tromey.com> * gdb.python/py-infthread.exp: Add tests for new_thread event. * gdb.python/py-inferior.exp: Add tests for new inferior events.
* nds32: Rename __BIT() to N32_BIT().Kuan-Lin Chen2017-09-118-55/+69
|
* Automatic date update in version.inGDB Administrator2017-09-111-1/+1
|
* Fix build breakage on GNU/Linux AArch64, take 2Sergio Durigan Junior2017-09-102-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The last commit unfortunately was not enough to fix the build breakage on AArch64. I made a mistake and did not test it alone on BuildBot, but along with another patch that was responsible for fixing the breakage. The failure is: In file included from /usr/include/string.h:640:0, from build-gnulib-gdbserver/import/string.h:41, from ../../../binutils-gdb/gdb/gdbserver/../common/common-defs.h:56, from ../../../binutils-gdb/gdb/gdbserver/server.h:22, from ../../../binutils-gdb/gdb/gdbserver/regcache.c:19: In function ‘void* memset(void*, int, size_t)’, inlined from ‘regcache* init_register_cache(regcache*, const target_desc*, unsigned char*)’ at ../../../binutils-gdb/gdb/gdbserver/regcache.c:150:50: /usr/include/aarch64-linux-gnu/bits/string3.h:81:32: error: call to ‘__warn_memset_zero_len’ declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror] __warn_memset_zero_len (); ^ In function ‘void* memset(void*, int, size_t)’, inlined from ‘regcache* get_thread_regcache(thread_info*, int)’ at ../../../binutils-gdb/gdb/gdbserver/regcache.c:57:60: /usr/include/aarch64-linux-gnu/bits/string3.h:81:32: error: call to ‘__warn_memset_zero_len’ declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror] __warn_memset_zero_len (); This is likely due to a GCC bug, because for some reason the compiler assumes that the third argument to the memset: memset (regcache->register_status, REG_UNAVAILABLE, VEC_length (tdesc_reg_p, regcache->tdesc->reg_defs)); is always zero, which is not always true. Anyway, the simple fix for this is to guard the memset calls with: if (!VEC_empty (tdesc_reg_p, regcache->tdesc->reg_defs)) This time, I made sure to regtest only this patch on BuildBot, and it finally solved the breakage. gdb/gdbserver/ChangeLog: 2017-09-10 Sergio Durigan Junior <sergiodj@redhat.com> * regcache.c (get_thread_regcache): Guard calls to "memset" with "!VEC_empty".
* Fix build breakage on GNU/Linux AArch64Sergio Durigan Junior2017-09-103-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes the build breakage that has been happening on AArch64 since September 5th. The breakage was introduced by the following commit: author Yao Qi <yao.qi@linaro.org> Tue, 5 Sep 2017 04:54:52 -0400 (09:54 +0100) committer Yao Qi <yao.qi@linaro.org> Tue, 5 Sep 2017 04:54:52 -0400 (09:54 +0100) commit f7000548a2b79d7e5cb924468117ca4245e6b820 Use VEC for target_desc.reg_defs The build log for this commit can be seen here: <https://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/2696/steps/compile%20gdb/logs/stdio> And the underlying problem is that the code is not calling the new function "allocate_target_description" to allocate the "struct target_desc" using "new" instead of XNEW, which end up not properly initializing the fields of the structure. Regtested on BuildBot. gdb/gdbserver/ChangeLog: 2017-09-10 Sergio Durigan Junior <sergiodj@redhat.com> * linux-low.c (handle_extended_wait): Use "allocate_target_description" instead of "XNEW". * linux-x86-low.c (initialize_low_arch): Likewise.
* gdb: Remove check for gdb_stderr == NULLAndrew Burgess2017-09-102-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recent changes made gdb_stderr a macro: #define gdb_stderr (*current_ui_gdb_stderr_ptr ()) and current_ui_gdb_stderr_ptr return this: &current_ui->m_gdb_stderr The problem is that this is undefined if current_ui is NULL, which can happen early on during gdb start up. If we run into an error during early gdb start up then we write the error message to gdb_stderr. However, if we are too early during the start up then current_ui is NULL, and using the gdb_stderr macro triggers undefined behaviour. We try to avoid this using a check 'gdb_stderr == NULL' which was fine before the recent changes, but now, still triggers undefined behaviour. A better check is instead 'current_ui == NULL' which is what I use in this patch. Triggering this failure is pretty hard, most of the really early errors are only triggered if pretty basic things are not as expected, for example, if the default signal handlers are not as expected. Seeing one of these errors trigger usually means that someone working on gdb has made an incorrect change. Still, the errors are present in gdb, and should we ever trigger one it would be nice if gdb didn't crash. For testing this change I've been applying this patch which adds an unconditional error into a function called early during gdb start up. Later in the same function is a real error call which, in some circumstances could be triggered: ## START ## diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c index d11a9ae006c..d75ba70f894 100644 --- a/gdb/common/signals-state-save-restore.c +++ b/gdb/common/signals-state-save-restore.c @@ -37,6 +37,9 @@ static sigset_t original_signal_mask; void save_original_signals_state (void) { + + internal_error (__FILE__, __LINE__, "example error"); + #ifdef HAVE_SIGACTION int i; int res; ## END ## gdb/ChangeLog: * utils.c (abort_with_message): Don't compare gdb_stderr to NULL, check current_ui instead. (internal_vproblem): Likewise.
* Automatic date update in version.inGDB Administrator2017-09-101-1/+1
|
* Remove unnecessary calls to is_mi_like_p in print_thread_info_1Simon Marchi2017-09-092-10/+10
| | | | | | | | | | | | | There are two calls to uiout->is_mi_like_p in the else branch of a if (uiout->is_mi_like_p ()), we already know they will return false. A bit lower, there are two if (!uiout->is_mi_like_p ()) that we can merge. gdb/ChangeLog: * thread.c (print_thread_info_1): Remove unnecessary calls to uiout->is_mi_like_p.
* Use std::vector in add_using_directiveTom Tromey2017-09-095-21/+24
| | | | | | | | | | | | | | | This changes add_using_directive to accept a std::vector and then changes the callers. This allows removing a cleanup. ChangeLog 2017-09-09 Tom Tromey <tom@tromey.com> * namespace.h (add_using_directive): Update. * namespace.c (add_using_directive): Change type of excludes to std::vector. * dwarf2read.c (read_import_statement): Use std::vector. (read_namespace): Update. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
* Use gdb::def_vector in create_sals_line_offsetTom Tromey2017-09-092-8/+7
| | | | | | | | | | This changes create_sals_line_offset to use gdb::def_vector, removing some cleanups. ChangeLog 2017-09-09 Tom Tromey <tom@tromey.com> * linespec.c (create_sals_line_offset): Use gdb::def_vector.
* Use gdb::byte_vector in pascal_object_print_valueTom Tromey2017-09-092-8/+9
| | | | | | | | | | | This changes pascal_object_print_value to use a gdb::byte_vector. This removes a cleanup. This change also points out how the previous code had a possible use-after-free bug. ChangeLog 2017-09-09 Tom Tromey <tom@tromey.com> * p-valprint.c (pascal_object_print_value): Use gdb::byte_vector.
View Lorry Controller Status