diff options
| -rw-r--r-- | gdbserver/ChangeLog | 13 | ||||
| -rw-r--r-- | gdbserver/linux-low.cc | 2 | ||||
| -rw-r--r-- | gdbserver/lynx-low.cc | 2 | ||||
| -rw-r--r-- | gdbserver/server.cc | 2 | ||||
| -rw-r--r-- | gdbserver/win32-low.cc | 2 |
5 files changed, 17 insertions, 4 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 7ed38d7dbf7..2b7fbb7c570 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,5 +1,18 @@ 2020-05-25 Michael Weghorn <m.weghorn@posteo.de> + PR gdbserver/25893 + * linux-low.cc (linux_process_target::create_inferior), + lynx-low.cc (lynx_process_target::create_inferior), + win32-low.cc (win32_process_target::create_inferior): Use + construct_inferior_arguments instead of stringify_argv + to get string representation which properly escapes + special characters. + * server.cc (handle_v_run): Just pass empty program arg + as such, since any further processing is now handled via + construct_inferior_arguments. + +2020-05-25 Michael Weghorn <m.weghorn@posteo.de> + * nto-low.cc (nto_process_target::create_inferior): Pass argv to spawnp function as char **. diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 3cd8d5594dc..8ba39252c0f 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -984,7 +984,7 @@ linux_process_target::create_inferior (const char *program, { maybe_disable_address_space_randomization restore_personality (cs.disable_randomization); - std::string str_program_args = stringify_argv (program_args); + std::string str_program_args = construct_inferior_arguments (program_args); pid = fork_inferior (program, str_program_args.c_str (), diff --git a/gdbserver/lynx-low.cc b/gdbserver/lynx-low.cc index 9aa140c1298..a8e4e6079bd 100644 --- a/gdbserver/lynx-low.cc +++ b/gdbserver/lynx-low.cc @@ -253,7 +253,7 @@ lynx_process_target::create_inferior (const char *program, const std::vector<char *> &program_args) { int pid; - std::string str_program_args = stringify_argv (program_args); + std::string str_program_args = construct_inferior_arguments (program_args); lynx_debug ("create_inferior ()"); diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 27d0931f793..0313d18bb24 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -2957,7 +2957,7 @@ handle_v_run (char *own_buf) else if (p == next_p) { /* Empty argument. */ - new_argv.push_back (xstrdup ("''")); + new_argv.push_back (xstrdup ("")); } else { diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 4eb63b7ca25..d5555a78fd2 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -693,7 +693,7 @@ win32_process_target::create_inferior (const char *program, DWORD flags; PROCESS_INFORMATION pi; DWORD err; - std::string str_program_args = stringify_argv (program_args); + std::string str_program_args = construct_inferior_arguments (program_args); char *args = (char *) str_program_args.c_str (); /* win32_wait needs to know we're not attaching. */ |