diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2016-01-21 21:00:25 -0500 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2021-05-17 00:42:55 -0400 |
| commit | 383861bd08c47a160f54351e6b8519140b9aad8e (patch) | |
| tree | dc43aadd66fbcc1f7cf18d8bebd7b14740086e48 /sim/msp430 | |
| parent | 92bc001e1f91390b8e009c29e75f4e8b9be02d76 (diff) | |
| download | binutils-gdb-383861bd08c47a160f54351e6b8519140b9aad8e.tar.gz | |
sim: invert sim_state storage
Currently all ports have to declare sim_state themselves in their
sim-main.h and then embed the common sim_state_base & sim_cpu in it.
This dynamic makes it impossible to share common object code among
multiple ports because the core data structure is always different.
Let's invert this relationship: common code declares sim_state, and
if the port actually needs state on a per-instance basis, it can use
the new arch_data field for it. Most ports don't actually use it,
so they don't need to declare anything at all.
This is the first in a series of changes: it adds a define to select
between the old & new layouts, then converts all the ports that don't
need custom state over to the new layout.
Diffstat (limited to 'sim/msp430')
| -rw-r--r-- | sim/msp430/ChangeLog | 5 | ||||
| -rw-r--r-- | sim/msp430/sim-main.h | 10 |
2 files changed, 7 insertions, 8 deletions
diff --git a/sim/msp430/ChangeLog b/sim/msp430/ChangeLog index 4664091de00..1ea283ca052 100644 --- a/sim/msp430/ChangeLog +++ b/sim/msp430/ChangeLog @@ -1,3 +1,8 @@ +2021-05-17 Mike Frysinger <vapier@gentoo.org> + + * sim-main.h (SIM_HAVE_COMMON_SIM_STATE): Define. + (struct sim_state): Delete. + 2021-05-16 Mike Frysinger <vapier@gentoo.org> * msp430-sim.c: Replace config.h include with defs.h. diff --git a/sim/msp430/sim-main.h b/sim/msp430/sim-main.h index 22a53b4c9d3..f98712c12e5 100644 --- a/sim/msp430/sim-main.h +++ b/sim/msp430/sim-main.h @@ -21,6 +21,8 @@ #ifndef _MSP430_MAIN_SIM_H_ #define _MSP430_MAIN_SIM_H_ +#define SIM_HAVE_COMMON_SIM_STATE + #include "sim-basics.h" #include "sim-signal.h" #include "msp430-sim.h" @@ -33,14 +35,6 @@ struct _sim_cpu sim_cpu_base base; }; -struct sim_state -{ - sim_cpu *cpu[MAX_NR_PROCESSORS]; - - /* Simulator specific members. */ - sim_state_base base; -}; - #define MSP430_CPU(sd) (STATE_CPU ((sd), 0)) #define MSP430_CPU_STATE(sd) (MSP430_CPU ((sd)->state)) |