diff options
author | Alan Modra <amodra@gmail.com> | 2016-05-31 20:34:47 +0930 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2016-05-31 20:34:47 +0930 |
commit | c12969f8b53659f0d70b5e049c49b97a96826a3f (patch) | |
tree | ec73abbf6a686869b8c5bd61388e70c15f0ab8b5 /libiberty | |
parent | c7022704e9919b724a9e935b4d0bae877946c735 (diff) | |
download | binutils-gdb-c12969f8b53659f0d70b5e049c49b97a96826a3f.tar.gz |
Don't needlessly clear xmemdup allocated memory.
* xmemdup.c (xmemdup): Use xmalloc rather than xcalloc.
Diffstat (limited to 'libiberty')
-rw-r--r-- | libiberty/ChangeLog | 4 | ||||
-rw-r--r-- | libiberty/xmemdup.c | 6 |
2 files changed, 8 insertions, 2 deletions
diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog index 358a6b0f586..c55af153a9b 100644 --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,7 @@ +2016-05-31 Alan Modra <amodra@gmail.com> + + * xmemdup.c (xmemdup): Use xmalloc rather than xcalloc. + 2016-01-27 Iain Buclaw <ibuclaw@gdcproject.org> * d-demangle.c (dlang_call_convention): Handle extern Objective-C diff --git a/libiberty/xmemdup.c b/libiberty/xmemdup.c index aa56f0bf572..4602afd7d9f 100644 --- a/libiberty/xmemdup.c +++ b/libiberty/xmemdup.c @@ -1,4 +1,4 @@ -/* xmemdup.c -- Duplicate a memory buffer, using xcalloc. +/* xmemdup.c -- Duplicate a memory buffer, using xmalloc. This trivial function is in the public domain. Jeff Garzik, September 1999. */ @@ -34,6 +34,8 @@ allocated, the remaining memory is zeroed. PTR xmemdup (const PTR input, size_t copy_size, size_t alloc_size) { - PTR output = xcalloc (1, alloc_size); + PTR output = xmalloc (alloc_size); + if (alloc_size > copy_size) + memset ((char *) output + copy_size, 0, alloc_size - copy_size); return (PTR) memcpy (output, input, copy_size); } |