diff options
| author | Tom Tromey <tom@tromey.com> | 2018-04-29 21:07:03 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-04-30 11:33:11 -0600 |
| commit | bbfa6f00867946985b954bbec233c0f25f14ac5c (patch) | |
| tree | cd2c5427f88f6276caa1f0eb6f895185a2aa3753 /gdb/value.h | |
| parent | 1831a9f9d3346dbf61202d2aba6935f0093487dd (diff) | |
| download | binutils-gdb-bbfa6f00867946985b954bbec233c0f25f14ac5c.tar.gz | |
Use new_reference for struct value
value_incref returned its argument just as a convenience, which in the
end turned out to only be used in precisely the cases where
new_reference helps. So, this patch changes value_incref to return
void and changes some value-using code to use new_reference.
I also noticed that the comments for value_incref and value_decref
were swapped, so this patch fixes those.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* varobj.c (install_new_value): Use new_reference.
* value.h (value_incref): Return void. Swap intro comment with
value_decref.
* value.c (set_value_parent): Use new_reference.
(value_incref): Return void. Update intro comment.
(release_value): Use new_reference.
* dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
Diffstat (limited to 'gdb/value.h')
| -rw-r--r-- | gdb/value.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/value.h b/gdb/value.h index b58f78998a1..4d75c966edd 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -88,12 +88,12 @@ struct value_print_options; struct value; -/* Decrease VAL's reference count. When the reference count drops to - 0, VAL will be freed. */ +/* Increase VAL's reference count. */ -extern struct value *value_incref (struct value *val); +extern void value_incref (struct value *val); -/* Increate VAL's reference count. VAL is returned. */ +/* Decrease VAL's reference count. When the reference count drops to + 0, VAL will be freed. */ extern void value_decref (struct value *val); |