revert 2007-01-11 Nathan Sidwell <nathan@codesourcery.com>

	* lib/gdb.exp (gdb_compile_test): New.
	(skip_ada_tests, skip_java_tests): New.
	(gdb_compile): Use gdb_compile_test for f77.
	* lib/ada.exp (gdb_compile_ada): Use gdb_compile_test to record result.
	* lib/java.exp (compile_java_from_source): Remove runtests check,
	use gdb_compile_test to record result.
	* gdb.ada/packed_array.exp, gdb.ada/fixed_points.exp,
	gdb.ada/exec_changed.exp, gdb.ada/start.exp,
	gdb.ada/watch_arg.exp, gdb.ada/null_record.exp,
	gdb.ada/array_return.exp, gdb.ada/arrayidx.exp,
	gdb.mi/mi-var-child-f.exp, gdb.fortran/types.exp,
	gdb.fortran/array-element.exp, gdb.fortran/subarray.exp,
	gdb.fortran/derived-type.exp, gdb.fortran/exprs.exp,
	gdb.java/jmisc.exp, gdb.java/jprint.exp,
	gdb.java/jv-print.exp, gdb.java/jmain.exp: Add language skip,
	adjust gdb_compile invocations.

3 files changed, 22 insertions, 43 deletions

diff --git a/gdb/testsuite/lib/ada.exp b/gdb/testsuite/lib/ada.exp
index 44d38a74e63..bf9c41238b1 100644
--- a/gdb/testsuite/lib/ada.exp
+++ b/gdb/testsuite/lib/ada.exp
@@ -425,8 +425,9 @@ proc gdb_compile_ada {source dest type options} {
     # gdb_compile to determine whether the build has succeeded or not.
     # We therefore simply check whether the dest file has been created
     # or not. Unless not present, the build has succeeded.
-    if [file exists $dest] { set result "" }
-    gdb_compile_test $source $result
-    return $result
+    if ![file exists $dest] {
+        unsupported "Ada compilation failed: $result"
+        return "Ada compilation failed."
+    }
 }
 
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 9c87cc75d88..4c440248040 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -1142,22 +1142,6 @@ proc default_gdb_start { } {
     return 0;
 }
 
-# Examine the output of compilation to determine whether compilation
-# failed or not.  If it failed determine whether it is due to missing
-# compiler or due to compiler error.  Report pass, fail or unsupported
-# as appropriate
-
-proc gdb_compile_test {src output} {
-    if { $output == "" } {
-	pass "compilation [file tail $src]"
-    } elseif { [regexp {^[a-zA-Z_0-9]+: Can't find [^ ]+\.$} $output] } {
-	unsupported "compilation [file tail $src]"
-    } else {
-	verbose -log "compilation failed: $output" 2
-	fail "compilation [file tail $src]"
-    }
-}
-
 # Return a 1 for configurations for which we don't even want to try to
 # test C++.
 
@@ -1168,6 +1152,7 @@ proc skip_cplus_tests {} {
     if { [istarget "h8300-*-*"] } {
 	return 1
     }
+
     # The C++ IO streams are too large for HC11/HC12 and are thus not
     # available.  The gdb C++ tests use them and don't compile.
     if { [istarget "m6811-*-*"] } {
@@ -1185,18 +1170,6 @@ proc skip_fortran_tests {} {
     return 0
 }
 
-# Return a 1 if I don't even want to try to test ada.
-
-proc skip_ada_tests {} {
-    return 0
-}
-
-# Return a 1 if I don't even want to try to test java.
-
-proc skip_java_tests {} {
-    return 0
-}
-
 # Run a test on the target to see if it supports vmx hardware.  Return 0 if so, 
 # 1 if it does not.  Based on 'check_vmx_hw_available' from the GCC testsuite.
 
@@ -1547,15 +1520,8 @@ proc gdb_compile {source dest type options} {
     set result [target_compile $source $dest $type $options];
     regsub "\[\r\n\]*$" "$result" "" result;
     regsub "^\[\r\n\]*" "$result" "" result;
-    
-    if {[lsearch $options quiet] < 0} {
-	# We shall update this on a per language basis, to avoid
-	# changing the entire testsuite in one go.
-	if {[lsearch $options f77] >= 0} {
-	    gdb_compile_test $source $result
-	} elseif { $result != "" } {
-	    clone_output "gdb compile failed, $result"
-	}
+    if { $result != "" && [lsearch $options quiet] == -1} {
+	clone_output "gdb compile failed, $result"
     }
     return $result;
 }
diff --git a/gdb/testsuite/lib/java.exp b/gdb/testsuite/lib/java.exp
index c445f9824ef..7916772e0be 100644
--- a/gdb/testsuite/lib/java.exp
+++ b/gdb/testsuite/lib/java.exp
@@ -91,19 +91,31 @@ proc java_init { args } {
 #
 proc compile_java_from_source { srcfile binfile compile_args } {
     global GCJ_UNDER_TEST
+    global runtests
     global java_initialized
 
     if { $java_initialized != 1 } { java_init }
 
+    set errname [file rootname [file tail $srcfile]]
+    if {! [runtest_file_p $runtests $errname]} {
+        return
+    }
+
     set args "compiler=$GCJ_UNDER_TEST"
     lappend args "additional_flags=--main=[file rootname [file tail $srcfile]]"
     if { $compile_args != "" } {
 	lappend args "additional_flags=$compile_args"
     }
 
-    set result [target_compile $srcfile ${binfile} ${binfile} executable $args]
-    gdb_compile_test $srcfile $result
-    return $result
+    if { $compile_args != "" } {
+	set errname "$errname $compile_args"
+    }
+
+    set x [target_compile $srcfile ${binfile} executable $args]
+    if { $x != "" } {
+	verbose "target_compile failed: $x" 2
+	return "$errname compilation from source";
+    }
 }
 
 # Local Variables: