diff options
author | Pedro Alves <palves@redhat.com> | 2013-06-07 17:31:09 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2013-06-07 17:31:09 +0000 |
commit | 4ec7020176a1aaae1adeeb1e1695975ebdc172ea (patch) | |
tree | 45b9789c9f3b5f7f6fb1cd87bc1be0744cd5730c /gdb/testsuite/gdb.trace/tfind.exp | |
parent | c5da8c7d174e38282889094b86153721fe3f5aca (diff) | |
download | binutils-gdb-4ec7020176a1aaae1adeeb1e1695975ebdc172ea.tar.gz |
Remove superfluous semicolons from testsuite throughout.
A few months ago semicolons after "return" were removed throughout the
testsuite. However, as I pointed out in review, they're unnecessary
not just after "return", but pretty much after any tcl command. ';'
is the command separator, and you only need it if there's another
command on the same line afterwards.
This patch was written by running:
$ find . -name "*.exp" | xargs grep -l ";\s*$" | xargs sed -i 's/\([^#][^\s*;]*\)\s*;\s*$/\1/'
and then undoing changes to comments, and lib/future.exp.
Tested on x86_64 Fedora 17.
gdb/testsuite/
2013-06-07 Pedro Alves <palves@redhat.com>
* boards/native-extended-gdbserver.exp: Remove semicolon.
* config/arm-ice.exp: Likewise.
* config/bfin.exp: Likewise.
* config/cygmon.exp: Likewise.
* config/h8300.exp: Likewise.
* config/monitor.exp: Likewise.
* config/sid.exp: Likewise.
* config/sim.exp: Likewise.
* config/slite.exp: Likewise.
* config/vx.exp: Likewise.
* gdb.arch/i386-bp_permanent.exp: Likewise.
* gdb.asm/asm-source.exp: Likewise.
* gdb.base/args.exp: Likewise.
* gdb.base/attach-pie-misread.exp: Likewise.
* gdb.base/auxv.exp: Likewise.
* gdb.base/bigcore.exp: Likewise.
* gdb.base/bitfields2.exp: Likewise.
* gdb.base/bitfields.exp: Likewise.
* gdb.base/break.exp: Likewise.
* gdb.base/break-interp.exp: Likewise.
* gdb.base/callfuncs.exp: Likewise.
* gdb.base/call-sc.exp: Likewise.
* gdb.base/commands.exp: Likewise.
* gdb.base/corefile.exp: Likewise.
* gdb.base/dbx.exp: Likewise.
* gdb.base/ending-run.exp: Likewise.
* gdb.base/exprs.exp: Likewise.
* gdb.base/funcargs.exp: Likewise.
* gdb.base/hbreak2.exp: Likewise.
* gdb.base/huge.exp: Likewise.
* gdb.base/list.exp: Likewise.
* gdb.base/memattr.exp: Likewise.
* gdb.base/overlays.exp: Likewise.
* gdb.base/printcmds.exp: Likewise.
* gdb.base/recurse.exp: Likewise.
* gdb.base/remotetimeout.exp: Likewise.
* gdb.base/reread.exp: Likewise.
* gdb.base/savedregs.exp: Likewise.
* gdb.base/scope.exp: Likewise.
* gdb.base/sepdebug.exp: Likewise.
* gdb.base/setshow.exp: Likewise.
* gdb.base/setvar.exp: Likewise.
* gdb.base/sigaltstack.exp: Likewise.
* gdb.base/siginfo-addr.exp: Likewise.
* gdb.base/siginfo.exp: Likewise.
* gdb.base/siginfo-obj.exp: Likewise.
* gdb.base/sigrepeat.exp: Likewise.
* gdb.base/sigstep.exp: Likewise.
* gdb.base/structs.exp: Likewise.
* gdb.base/testenv.exp: Likewise.
* gdb.base/twice.exp: Likewise.
* gdb.base/valgrind-db-attach.exp: Likewise.
* gdb.base/valgrind-infcall.exp: Likewise.
* gdb.base/varargs.exp: Likewise.
* gdb.base/watchpoint.exp: Likewise.
* gdb.cp/gdb1355.exp: Likewise.
* gdb.cp/misc.exp: Likewise.
* gdb.disasm/hppa.exp: Likewise.
* gdb.disasm/t01_mov.exp: Likewise.
* gdb.disasm/t02_mova.exp: Likewise.
* gdb.disasm/t03_add.exp: Likewise.
* gdb.disasm/t04_sub.exp: Likewise.
* gdb.disasm/t05_cmp.exp: Likewise.
* gdb.disasm/t06_ari2.exp: Likewise.
* gdb.disasm/t07_ari3.exp: Likewise.
* gdb.disasm/t08_or.exp: Likewise.
* gdb.disasm/t09_xor.exp: Likewise.
* gdb.disasm/t10_and.exp: Likewise.
* gdb.disasm/t11_logs.exp: Likewise.
* gdb.disasm/t12_bit.exp: Likewise.
* gdb.disasm/t13_otr.exp: Likewise.
* gdb.gdb/selftest.exp: Likewise.
* gdb.hp/gdb.base-hp/callfwmall.exp: Likewise.
* gdb.mi/mi-reverse.exp: Likewise.
* gdb.pascal/floats.exp: Likewise.
* gdb.python/py-inferior.exp: Likewise.
* gdb.threads/attach-into-signal.exp: Likewise.
* gdb.threads/pthreads.exp: Likewise.
* gdb.threads/thread_events.exp: Likewise.
* gdb.threads/watchthreads.exp: Likewise.
* gdb.trace/actions-changed.exp: Likewise.
* gdb.trace/actions.exp: Likewise.
* gdb.trace/ax.exp: Likewise.
* gdb.trace/backtrace.exp: Likewise.
* gdb.trace/change-loc.exp: Likewise.
* gdb.trace/deltrace.exp: Likewise.
* gdb.trace/disconnected-tracing.exp: Likewise.
* gdb.trace/ftrace.exp: Likewise.
* gdb.trace/infotrace.exp: Likewise.
* gdb.trace/passc-dyn.exp: Likewise.
* gdb.trace/passcount.exp: Likewise.
* gdb.trace/pending.exp: Likewise.
* gdb.trace/qtro.exp: Likewise.
* gdb.trace/range-stepping.exp: Likewise.
* gdb.trace/report.exp: Likewise.
* gdb.trace/save-trace.exp: Likewise.
* gdb.trace/status-stop.exp: Likewise.
* gdb.trace/strace.exp: Likewise.
* gdb.trace/tfile.exp: Likewise.
* gdb.trace/tfind.exp: Likewise.
* gdb.trace/trace-break.exp: Likewise.
* gdb.trace/tracecmd.exp: Likewise.
* gdb.trace/trace-mt.exp: Likewise.
* gdb.trace/tspeed.exp: Likewise.
* gdb.trace/tsv.exp: Likewise.
* gdb.trace/while-stepping.exp: Likewise.
* lib/gdb.exp: Likewise.
* lib/gdbserver-support.exp: Likewise.
* lib/java.exp: Likewise.
* lib/mi-support.exp: Likewise.
* lib/pascal.exp: Likewise.
* lib/prompt.exp: Likewise.
* lib/trace-support.exp: Likewise.
Diffstat (limited to 'gdb/testsuite/gdb.trace/tfind.exp')
-rw-r--r-- | gdb/testsuite/gdb.trace/tfind.exp | 58 |
1 files changed, 29 insertions, 29 deletions
diff --git a/gdb/testsuite/gdb.trace/tfind.exp b/gdb/testsuite/gdb.trace/tfind.exp index 9ecc6796263..f66ee5de092 100644 --- a/gdb/testsuite/gdb.trace/tfind.exp +++ b/gdb/testsuite/gdb.trace/tfind.exp @@ -15,7 +15,7 @@ # This file was written by Michael Snyder (msnyder@cygnus.com) -load_lib "trace-support.exp"; +load_lib "trace-support.exp" gdb_exit @@ -73,10 +73,10 @@ if { ![gdb_target_supports_trace] } then { # define relative source line numbers: # all subsequent line numbers are relative to this first one (baseline) -set baseline [gdb_find_recursion_test_baseline $srcfile]; +set baseline [gdb_find_recursion_test_baseline $srcfile] if { $baseline == -1 } then { fail "Could not find gdb_recursion_test function" - return; + return } set testline1 [expr $baseline + 1] @@ -98,7 +98,7 @@ set tdp5 [gdb_gettpnum $testline5] if { $tdp1 <= 0 || $tdp2 <= 0 || $tdp3 <= 0 || \ $tdp4 <= 0 || $tdp5 <= 0 } then { fail "setting tracepoints" - return; + return } # 6.1 test tstart command @@ -160,15 +160,15 @@ gdb_test "tstatus" "Trace stopped by a tstop command.*" \ "test tstatus off after tstop" ## record starting PC -set save_pc [gdb_readexpr "(unsigned long) \$pc"]; +set save_pc [gdb_readexpr "(unsigned long) \$pc"] if { $save_pc == -1 } then { fail "could not read PC" - return; + return } # 8.7 tfind start ## check $trace_frame == 0 -gdb_tfind_test "8.7: tfind start command" "start" "0"; +gdb_tfind_test "8.7: tfind start command" "start" "0" ## check $pc != startPC gdb_test "printf \"x \%d x\\n\", \$pc != $save_pc" \ "x 1 x" \ @@ -176,7 +176,7 @@ gdb_test "printf \"x \%d x\\n\", \$pc != $save_pc" \ # 8.8 tfind none ## check $trace_frame == -1 -gdb_tfind_test "8.8: tfind none" "none" "-1"; +gdb_tfind_test "8.8: tfind none" "none" "-1" ## check $pc == startPC gdb_test "printf \"x \%d x\\n\", \$pc == $save_pc" \ "x 1 x" \ @@ -184,7 +184,7 @@ gdb_test "printf \"x \%d x\\n\", \$pc == $save_pc" \ # 8.9 tfind end ## check $trace_frame == -1 -gdb_tfind_test "8.9: tfind end, selects no frame" "end" "-1"; +gdb_tfind_test "8.9: tfind end, selects no frame" "end" "-1" ## check $pc == startPC gdb_test "printf \"x \%d x\\n\", \$pc == $save_pc" \ "x 1 x" \ @@ -217,39 +217,39 @@ gdb_test "printf \"x \%d x\\n\", \$trace_frame == -3" "x 0 x" \ # 8.10 tfind <no arg> ## check $trace_frame += 1 -gdb_tfind_test "8.10: tfind start" "start" "0"; +gdb_tfind_test "8.10: tfind start" "start" "0" gdb_test "print \$trace_line" "$baseline" \ "8.10: tfind 0 (correct line $baseline)" -gdb_tfind_test "8.10: tfind noargument 1" "" "1"; +gdb_tfind_test "8.10: tfind noargument 1" "" "1" gdb_test "print \$trace_line" "$testline2" \ "8.10: tfind 1 (correct line $testline2)" -gdb_tfind_test "8.10: tfind noargument 2" "" "2"; +gdb_tfind_test "8.10: tfind noargument 2" "" "2" gdb_test "print \$trace_line" "$testline3" \ "8.10: tfind 2 (correct line $testline3)" -gdb_tfind_test "8.10: tfind noargument 3" "" "3"; +gdb_tfind_test "8.10: tfind noargument 3" "" "3" gdb_test "print \$trace_line" "$testline4" \ "8.10: tfind 3 (correct line $testline4)" -gdb_tfind_test "8.11: tfind 3" "3" "3"; +gdb_tfind_test "8.11: tfind 3" "3" "3" gdb_test "print \$trace_line" "$testline4" \ "8.11: tfind 3 (correct line $testline4)" -gdb_tfind_test "8.11: tfind backward 2" "-" "2"; +gdb_tfind_test "8.11: tfind backward 2" "-" "2" gdb_test "print \$trace_line" "$testline3" \ "8.11: tfind 2 (correct line $testline3)" -gdb_tfind_test "8.11: tfind backward 1" "-" "1"; +gdb_tfind_test "8.11: tfind backward 1" "-" "1" gdb_test "print \$trace_line" "$testline2" \ "8.11: tfind 1 (correct line $testline2)" -gdb_tfind_test "8.11: tfind backward 0" "-" "0"; +gdb_tfind_test "8.11: tfind backward 0" "-" "0" gdb_test "print \$trace_line" "$baseline" \ "8.11: tfind 0 (correct line $baseline)" -gdb_tfind_test "8.12: tfind none" "none" "-1"; +gdb_tfind_test "8.12: tfind none" "none" "-1" gdb_tfind_test "8.12: tfind tracepoint <n>" "tracepoint $tdp2" \ - "\$tracepoint" "$tdp2"; + "\$tracepoint" "$tdp2" gdb_test "print \$trace_line" "$testline2" \ "8.12: tfind tracepoint <n> (line $testline2)" -gdb_tfind_test "8.25: tfind none" "none" "-1"; +gdb_tfind_test "8.25: tfind none" "none" "-1" gdb_test "tfind tracepoint 0" "failed to find.*" \ "8.25: tfind tracepoint rejects zero" gdb_test "tfind tracepoint 32767" "failed to find.*" \ @@ -259,24 +259,24 @@ gdb_test "tfind tracepoint -1" "failed to find.*" \ # 8.37 tfind tracepoint n where n no longer exists (but used to) gdb_test_no_output "delete trace $tdp2" "" -gdb_tfind_test "8.37: tfind none" "none" "-1"; +gdb_tfind_test "8.37: tfind none" "none" "-1" gdb_tfind_test "8.37: tfind deleted tracepoint" \ "tracepoint $tdp2" \ - "\$tracepoint" "$tdp2"; + "\$tracepoint" "$tdp2" gdb_test "print \$trace_line" "$testline2" \ "8.37: tfind deleted tracepoint (line $testline2)" # 8.13 tfind tracepoint <no arg> ## check $tracepoint same before and after, $trace_frame changed -gdb_tfind_test "8.13: tfind none" "none" "-1"; +gdb_tfind_test "8.13: tfind none" "none" "-1" gdb_tfind_test "8.13: tracepoint $tdp1" "tracepoint $tdp1" \ - "\$tracepoint" "$tdp1"; + "\$tracepoint" "$tdp1" gdb_test "print \$trace_line" "$baseline" \ "8.13: tfind tracepoint $tdp1 (line $baseline)" gdb_test_no_output "set \$save_frame = \$trace_frame" "" gdb_tfind_test "8.13: tracepoint <no arg>" "tracepoint" \ - "\$tracepoint" "$tdp1"; + "\$tracepoint" "$tdp1" gdb_test "printf \"x \%d x\\n\", \$trace_frame == \$save_frame" \ "x 0 x" \ "8.13: tracepoint <no arg>, tracepoint number unchanged" @@ -299,7 +299,7 @@ gdb_test "print \$trace_line" "$testline4" \ gdb_test_no_output "set \$test_pc = \$pc" "" gdb_tfind_test "8.14: tfind none" "none" "-1" -gdb_tfind_test "8.14: tfind pc" "pc \$test_pc" "\$trace_frame != -1" "1"; +gdb_tfind_test "8.14: tfind pc" "pc \$test_pc" "\$trace_frame != -1" "1" gdb_test "print \$trace_line" "$testline4" \ "8.14: tfind pc x (line $testline4)" gdb_test "printf \"x \%d x\\n\", \$pc == \$test_pc" \ @@ -347,13 +347,13 @@ gdb_test "disassemble gdb_c_test" \ gdb_test "tfind line 0" \ "out of range.*|failed to find.*|No line 0 in .*" \ - "8.18: tfind line 0"; + "8.18: tfind line 0" gdb_test "tfind line 32767" \ "out of range.*|failed to find.*|No line 32767 in .*" \ - "8.27: tfind line 32767"; + "8.27: tfind line 32767" gdb_test "tfind line NoSuChFiLe.c:$baseline" \ "No source file named.*" \ - "8.27: tfind line in bad source file"; + "8.27: tfind line in bad source file" # 8.32 tfind invalid subcommand (tfind foo) ## check error |