diff options
| author | Pedro Alves <palves@redhat.com> | 2014-09-11 13:04:14 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2014-09-11 13:04:14 +0100 |
| commit | 4c92ff2c35392b68ee9172af979483b32aaa3d7b (patch) | |
| tree | d0e6d784dc0924ee5c6aa2e5b9aa38cd56e2f4a0 /gdb/testsuite/gdb.server/ext-attach.exp | |
| parent | bd9269f70c70b1218b0eb73a6f487d6ca481e5ac (diff) | |
| download | binutils-gdb-4c92ff2c35392b68ee9172af979483b32aaa3d7b.tar.gz | |
testsuite: refactor spawn and wait for attach
Several places in the testsuite have a copy of a snippet of code that
spawns a test program, waits a bit, and then does some PID munging for
Cygwin. This is in order to have GDB attach to the spawned program.
This refactors all that to a common procedure.
(multi-attach.exp wants to spawn multiple processes, so this makes the
new procedure's interface work with lists.)
Tested on x86_64 Fedora 20.
gdb/testsuite/ChangeLog:
2014-09-11 Pedro Alves <palves@redhat.com>
* lib/gdb.exp (spawn_wait_for_attach): New procedure.
* gdb.base/attach.exp (do_attach_tests, do_call_attach_tests)
(do_command_attach_tests): Use spawn_wait_for_attach.
* gdb.base/solib-overlap.exp: Likewise.
* gdb.multi/multi-attach.exp: Likewise.
* gdb.python/py-prompt.exp: Likewise.
* gdb.python/py-sync-interp.exp: Likewise.
* gdb.server/ext-attach.exp: Likewise.
Diffstat (limited to 'gdb/testsuite/gdb.server/ext-attach.exp')
| -rw-r--r-- | gdb/testsuite/gdb.server/ext-attach.exp | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/gdb/testsuite/gdb.server/ext-attach.exp b/gdb/testsuite/gdb.server/ext-attach.exp index 5f7bac48dbb..9baeeb732f9 100644 --- a/gdb/testsuite/gdb.server/ext-attach.exp +++ b/gdb/testsuite/gdb.server/ext-attach.exp @@ -44,15 +44,7 @@ gdbserver_start_extended gdb_test_no_output "set remote exec-file $target_exec" "set remote exec-file" -# Start the program running and then wait for a bit, to be sure -# that it can be attached to. -set testpid [eval exec $binfile &] -exec sleep 2 -if { [istarget "*-*-cygwin*"] } { - # testpid is the Cygwin PID, GDB uses the Windows PID, which might be - # different due to the way fork/exec works. - set testpid [ exec ps -e | gawk "{ if (\$1 == $testpid) print \$4; }" ] -} +set testpid [spawn_wait_for_attach $binfile] gdb_test "attach $testpid" \ "Attaching to program: .*, process $testpid.*(in|at).*" \ |