diff options
author | Luis Machado <lgustavo@codesourcery.com> | 2014-10-17 11:28:17 -0300 |
---|---|---|
committer | Luis Machado <lgustavo@codesourcery.com> | 2014-10-17 11:28:17 -0300 |
commit | a80db0157c31d3f0fbb37ea40384b11041429a2f (patch) | |
tree | 59f7ba93c9c0637d6649db8a4022a3d8fbb66465 /gdb/testsuite/gdb.reverse/break-precsave.exp | |
parent | b22089abcba7cc3be26a9ab7d60e01299ac13ea0 (diff) | |
download | binutils-gdb-a80db0157c31d3f0fbb37ea40384b11041429a2f.tar.gz |
Fix mingw32 failures due to incorrect directory separator in pattern
Some testcases, mostly gdb.reverse ones, assume the presence of a
'/' directory separator before the source file name. This is
incorrect for mingw32 hosts, generating false failures for those
tests.
I attempted to catch most of the occurrences of the pattern
".*/$srcfile" and replaced them with ".*$srcfile". The latter
is used elsewhere in the testsuite. The resulting patch is attached.
I also see other occurrences of the same assumption throughout the
testsuite, but usually they are arguments for function calls and i
seem to recall either the test harness or GDB deals with those
paths properly.
gdb/testsuite:
2014-10-17 Luis Machado <lgustavo@codesourcery.com>
* gdb.guile/scm-breakpoint.exp: Do not assume any
directory separators when matching source file paths.
* gdb.python/py-breakpoint.exp: Likewise.
* gdb.reverse/break-precsave.exp: Likewise.
* gdb.reverse/break-reverse.exp: Likewise.
* gdb.reverse/consecutive-precsave.exp: Likewise.
* gdb.reverse/finish-precsave.exp: Likewise.
* gdb.reverse/finish-reverse-bkpt.exp: Likewise.
* gdb.reverse/finish-reverse.exp: Likewise.
* gdb.reverse/i386-precsave.exp: Likewise.
* gdb.reverse/i387-env-reverse.exp: Likewise.
* gdb.reverse/i387-stack-reverse.exp: Likewise.
* gdb.reverse/machinestate-precsave.exp: Likewise.
* gdb.reverse/machinestate.exp: Likewise.
* gdb.reverse/sigall-precsave.exp: Likewise.
* gdb.reverse/solib-precsave.exp: Likewise.
* gdb.reverse/step-precsave.exp: Likewise.
* gdb.reverse/until-precsave.exp: Likewise.
* gdb.reverse/watch-precsave.exp: Likewise.
* gdb.reverse/watch-reverse.exp: Likewise.
Diffstat (limited to 'gdb/testsuite/gdb.reverse/break-precsave.exp')
-rw-r--r-- | gdb/testsuite/gdb.reverse/break-precsave.exp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/gdb/testsuite/gdb.reverse/break-precsave.exp b/gdb/testsuite/gdb.reverse/break-precsave.exp index 3206e3c144b..f77054c0af3 100644 --- a/gdb/testsuite/gdb.reverse/break-precsave.exp +++ b/gdb/testsuite/gdb.reverse/break-precsave.exp @@ -45,7 +45,7 @@ proc precsave_tests {} { } gdb_test "break $end_location" \ - "Breakpoint $decimal at .*/$srcfile, line $end_location\." \ + "Breakpoint $decimal at .*$srcfile, line $end_location\." \ "BP at end of main" gdb_test "continue" "Breakpoint .* end of main .*" "run to end of main" @@ -69,10 +69,10 @@ proc precsave_tests {} { "Breakpoint $decimal at .* line $bar_location\." \ "set breakpoint on bar" - gdb_continue_to_breakpoint "foo" ".*/$srcfile:$foo_location.*" - gdb_continue_to_breakpoint "bar" ".*/$srcfile:$bar_location.*" + gdb_continue_to_breakpoint "foo" ".*$srcfile:$foo_location.*" + gdb_continue_to_breakpoint "bar" ".*$srcfile:$bar_location.*" gdb_test_multiple "continue" "go to end of main forward" { - -re ".*Breakpoint $decimal,.*/$srcfile:$end_location.*$gdb_prompt $" { + -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $" { pass "go to end of main forward" } -re "No more reverse-execution history.* end of main .*$gdb_prompt $" { @@ -82,11 +82,11 @@ proc precsave_tests {} { gdb_test_no_output "set exec-direction reverse" "set reverse" - gdb_continue_to_breakpoint "bar backward" ".*/$srcfile:$bar_location.*" - gdb_continue_to_breakpoint "foo backward" ".*/$srcfile:$foo_location.*" + gdb_continue_to_breakpoint "bar backward" ".*$srcfile:$bar_location.*" + gdb_continue_to_breakpoint "foo backward" ".*$srcfile:$foo_location.*" gdb_test_multiple "continue" "main backward" { - -re ".*Breakpoint $decimal,.*/$srcfile:$main_location.*$gdb_prompt $" { + -re ".*Breakpoint $decimal,.*$srcfile:$main_location.*$gdb_prompt $" { pass "main backward" } -re "No more reverse-execution history.* break in main .*$gdb_prompt $" { @@ -96,11 +96,11 @@ proc precsave_tests {} { gdb_test_no_output "set exec-direction forward" "set forward" - gdb_continue_to_breakpoint "foo" ".*/$srcfile:$foo_location.*" - gdb_continue_to_breakpoint "bar" ".*/$srcfile:$bar_location.*" + gdb_continue_to_breakpoint "foo" ".*$srcfile:$foo_location.*" + gdb_continue_to_breakpoint "bar" ".*$srcfile:$bar_location.*" gdb_test_multiple "continue" "end of record log" { - -re ".*Breakpoint $decimal,.*/$srcfile:$end_location.*$gdb_prompt $" { + -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $" { pass "end of record log" } -re "No more reverse-execution history.* end of main .*$gdb_prompt $" { |