diff options
| author | Tom Tromey <tom@tromey.com> | 2021-12-26 22:03:09 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-01-06 08:56:20 -0700 |
| commit | 41e321a8973edf99f69eb3f11cc076a69be726af (patch) | |
| tree | 449b72055dc8ecd8394d052cfda9a1947240272b /gdb/target.c | |
| parent | bc521517b7058a231a08bf8f3deae7cd41cd62d7 (diff) | |
| download | binutils-gdb-41e321a8973edf99f69eb3f11cc076a69be726af.tar.gz | |
Use target_announce_detach in more targets
target_announce_detach was added in commit 0f48b757 ("Factor out
"Detaching from program" message printing"). There, Pedro wrote:
(For now, I left the couple targets that print this a bit differently
alone. Maybe this could be further pulled out into infcmd.c. If we
did that, and those targets want to continue printing differently,
this new function could be converted to a target method.)
It seems to me that the differences aren't very big, and in some cases
other targets handled the output a bit more nicely. In particular,
some targets will print a different message when exec_file==NULL,
rather than printing the same output with an empty string as
exec_file.
This patch incorporates the nicer output into target_announce_detach,
then changes the remaining ports to use this function.
Diffstat (limited to 'gdb/target.c')
| -rw-r--r-- | gdb/target.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/gdb/target.c b/gdb/target.c index a48845d6add..c25ce692538 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -3628,13 +3628,14 @@ target_announce_detach (int from_tty) if (!from_tty) return; - exec_file = get_exec_file (0); - if (exec_file == NULL) - exec_file = ""; - pid = inferior_ptid.pid (); - printf_unfiltered (_("Detaching from program: %s, %s\n"), exec_file, - target_pid_to_str (ptid_t (pid)).c_str ()); + exec_file = get_exec_file (0); + if (exec_file == nullptr) + printf_unfiltered ("Detaching from pid %s\n", + target_pid_to_str (ptid_t (pid)).c_str ()); + else + printf_unfiltered (_("Detaching from program: %s, %s\n"), exec_file, + target_pid_to_str (ptid_t (pid)).c_str ()); } /* See target.h */ |