diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-08-02 08:12:31 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-08-05 07:36:28 -0600 |
| commit | 8abfcabcb49fcd8b95854a5b59e7928e3c6000ff (patch) | |
| tree | 893690767cf48b6862208522976afc8d9c9183f3 /gdb/printcmd.c | |
| parent | 23d188c74e7481bb0af3c42b84fc9cb0c94267e5 (diff) | |
| download | binutils-gdb-8abfcabcb49fcd8b95854a5b59e7928e3c6000ff.tar.gz | |
Use _() in calls to build_help
Currently some code in gdb uses build_help with N_(), like:
static const std::string compile_print_help
= gdb::option::build_help (N_("\
I believe this is incorrect. The N_ macro is used to mark text that
should end up in the message catalog, but which will be translated by
a later call to gettext.
However, in this case, there is no later call to gettext, so (if gdb
had translations), this text would remain untranslated.
Instead, I think using the ordinary _() macro is correct here.
Translators will have to know to preserve "%OPTIONS%" in the text --
but that seems both unavoidable and fine.
Tested by rebuilding as there's not much else to do.
gdb/ChangeLog
2019-08-05 Tom Tromey <tromey@adacore.com>
* compile/compile.c (_initialize_compile): Use _(), not N_().
* thread.c (_initialize_thread): Use _(), not N_().
* stack.c (_initialize_stack): Use _(), not N_().
* printcmd.c (_initialize_printcmd): Use _(), not N_().
Diffstat (limited to 'gdb/printcmd.c')
| -rw-r--r-- | gdb/printcmd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 1faa09eee71..0c368a6f6d8 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -2848,7 +2848,7 @@ This may usually be abbreviated to simply \"set\"."), const auto print_opts = make_value_print_options_def_group (nullptr); - static const std::string print_help = gdb::option::build_help (N_("\ + static const std::string print_help = gdb::option::build_help (_("\ Print value of expression EXP.\n\ Usage: print [[OPTION]... --] [/FMT] [EXP]\n\ \n\ |