diff options
author | Pedro Alves <palves@redhat.com> | 2016-08-04 17:40:26 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2016-08-04 17:40:26 +0100 |
commit | 4265c12fbbf4e7b181e3136ecbe1644121242abc (patch) | |
tree | 2070e80b92c6a683ad45f22d2647c0ceb9569155 /gdb/mi | |
parent | 6f67973b4280cfd045e632a3340becd16e43b4b1 (diff) | |
download | binutils-gdb-users/palves/restore-signal-dispositions.tar.gz |
Fix PR gdb/18653: gdb disturbs inferior's inherited signal dispositionsusers/palves/restore-signal-dispositions
Today I was helping Phil debug something on the new C++ compile
support, and we noticed that when debugging gdb under gdb, the
inferior gdb behaved differently compared to when it was not being
debugged. Turned out to be a manifestation of PR gdb/18653.
Since the exec family of functions do not reset the signal disposition
of signals that are set to SIG_IGN:
http://pubs.opengroup.org/onlinepubs/7908799/xsh/execve.html
Signals set to the default action (SIG_DFL) in the calling process
image are set to the default action in the new process
image. Signals set to be ignored (SIG_IGN) by the calling process
image are set to be ignored by the new process image. Signals set to
be caught by the calling process image are set to the default action
in the new process image (see <signal.h>).
gdb's (or gdbserver's) own signal handling should not interfere with
the signal dispositions their spawned children inherit. However, it
currently does. For example, some paths in gdb cause SIGPIPE to be
set to SIG_IGN, and as consequence, the child starts with SIGPIPE to
set to SIG_IGN too, even though gdb was started with SIGPIPE set to
SIG_DFL.
In order to be transparent, when spawning new child processes to debug
(with "run", etc.), reset all signal dispositions back to what was
originally inherited from gdb/gdbserver's parent, just before execing
the target program to debug.
gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
PR gdb/18653
* Makefile.in (SFILES): Add
common/signal-dispositions-save-restore.c.
(HFILES_NO_SRCDIR): Add common/signal-dispositions-save-restore.h.
(COMMON_OBS): Add signal-dispositions-save-restore.o.
(signal-dispositions-save-restore.o): New rule.
* configure: Regenerate.
* fork-child.c: Include "signal-dispositions-save-restore.h".
(fork_inferior): Call restore_original_signal_dispositions.
* main.c: Include "signal-dispositions-save-restore.h".
(captured_main): Call save_original_signal_dispositions.
* common/common.m4: Add sigaction to AC_CHECK_FUNCS checks.
* common/signal-dispositions-save-restore.c: New file.
* common/signal-dispositions-save-restore.h: New file.
gdb/gdbserver/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
PR gdb/18653
* Makefile.in (OBS): Add signal-dispositions-save-restore.o.
(signal-dispositions-save-restore.o): New rule.
* config.in: Regenerate.
* configure: Regenerate.
* linux-low.c: Include "signal-dispositions-save-restore.h".
(linux_create_inferior): Call
restore_original_signal_dispositions.
* server.c: Include "signal-dispositions-save-restore.h".
(captured_main): Call save_original_signal_dispositions.
gdb/testsuite/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
PR gdb/18653
* gdb.base/signal-dispositions-child.c: New file.
* gdb.base/signal-dispositions-child.exp: New file.
* gdb.gdb/selftest.exp (do_steps_and_nexts): Add new pattern.
Diffstat (limited to 'gdb/mi')
0 files changed, 0 insertions, 0 deletions