diff options
author | Gary Benson <gbenson@redhat.com> | 2014-08-06 11:56:25 +0100 |
---|---|---|
committer | Gary Benson <gbenson@redhat.com> | 2014-08-28 15:06:45 +0100 |
commit | 38e08fcac0966f52dac0ec97870fdea4de304d86 (patch) | |
tree | aab65459f955f6622d7544965c141af8b5785926 /gdb/gdbserver/thread-db.c | |
parent | 6aefca7e4978b93f502ff8123a6c3cab6e0171f1 (diff) | |
download | binutils-gdb-38e08fcac0966f52dac0ec97870fdea4de304d86.tar.gz |
Straightforward fatal to internal_error conversions
This commit replaces most of the calls to fatal that represent
internal errors with calls to internal_error, either directly
or via gdb_assert and gdb_assert_not_reached.
gdb/gdbserver/ChangeLog:
* inferiors.c (get_thread_process): Replace check with gdb_assert.
* linux-low.c (linux_wait_for_event_filtered): Replace fatal with
internal_error.
(linux_resume_one_lwp): Likewise.
* linux-x86-low.c (x86_siginfo_fixup): Replace checks with
gdb_assert.
* mem-break.c (raw_bkpt_type_to_target_hw_bp_type): Replace fatal
with internal_error.
* regcache.c (get_thread_regcache): Replace check with gdb_assert.
(init_register_cache): Replace fatal with gdb_assert_not_reached.
(find_register_by_name): Replace fatal with internal_error.
(find_regno): Likewise.
* tdesc.c (init_target_desc): Replace check with gdb_assert.
* thread-db.c (thread_db_create_event): Likewise.
(thread_db_load_search): Likewise.
(try_thread_db_load_1): Likewise.
* tracepoint.c (get_jump_space_head): Replace fatal with
internal_error.
(claim_trampoline_space): Likewise.
(have_fast_tracepoint_trampoline_buffer): Likewise.
(cmd_qtstart): Likewise.
(stop_tracing): Likewise.
(fast_tracepoint_collecting): Likewise.
(target_malloc): Likewise.
(download_tracepoint): Likewise.
(download_trace_state_variables): Replace check with gdb_assert.
(upload_fast_traceframes): Replace fatal with internal_error.
Diffstat (limited to 'gdb/gdbserver/thread-db.c')
-rw-r--r-- | gdb/gdbserver/thread-db.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/gdb/gdbserver/thread-db.c b/gdb/gdbserver/thread-db.c index d69c9e43f81..eabfe207204 100644 --- a/gdb/gdbserver/thread-db.c +++ b/gdb/gdbserver/thread-db.c @@ -193,8 +193,7 @@ thread_db_create_event (CORE_ADDR where) struct lwp_info *lwp; struct thread_db *thread_db = current_process ()->private->thread_db; - if (thread_db->td_ta_event_getmsg_p == NULL) - fatal ("unexpected thread_db->td_ta_event_getmsg_p == NULL"); + gdb_assert (thread_db->td_ta_event_getmsg_p != NULL); if (debug_threads) debug_printf ("Thread creation event.\n"); @@ -561,8 +560,7 @@ thread_db_load_search (void) struct thread_db *tdb; struct process_info *proc = current_process (); - if (proc->private->thread_db != NULL) - fatal ("unexpected: proc->private->thread_db != NULL"); + gdb_assert (proc->private->thread_db == NULL); tdb = xcalloc (1, sizeof (*tdb)); proc->private->thread_db = tdb; @@ -607,8 +605,7 @@ try_thread_db_load_1 (void *handle) struct thread_db *tdb; struct process_info *proc = current_process (); - if (proc->private->thread_db != NULL) - fatal ("unexpected: proc->private->thread_db != NULL"); + gdb_assert (proc->private->thread_db == NULL); tdb = xcalloc (1, sizeof (*tdb)); proc->private->thread_db = tdb; |