diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-07-02 12:06:06 +0100 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-07-17 16:24:32 +0100 |
| commit | 6b78c3f83c8bcbfa714aab7627ece9673b2d602a (patch) | |
| tree | e8224084dbf069be1e592ea23aeefc509ddf1316 /gdb/gdbarch.sh | |
| parent | d72a9b85651c872378f6dd732cb578f6f055a9b3 (diff) | |
| download | binutils-gdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.tar.gz | |
gdb: Remove a non-const reference parameter
Non-const reference parameter should be avoided according to the GDB
coding standard:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead
This commit updates the gdbarch method gdbarch_stap_adjust_register,
and the one implementation i386_stap_adjust_register to avoid using a
non-const reference parameter.
I've also removed the kfail from the testsuite for bug 24541, as this
issue is now resolved.
gdb/ChangeLog:
PR breakpoints/24541
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
* gdbarch.sh: Adjust return type and parameter types for
'stap_adjust_register'.
(i386_stap_adjust_register): Adjust signature and return new
register name.
* stap-probe.c (stap_parse_register_operand): Adjust use of
'gdbarch_stap_adjust_register'.
gdb/testsuite/ChangeLog:
PR breakpoints/24541
* gdb.mi/mi-catch-cpp-exceptions.exp: Remove kfail due to 24541.
Diffstat (limited to 'gdb/gdbarch.sh')
| -rwxr-xr-x | gdb/gdbarch.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index f3d1bf489ac..2f9fbbc56cd 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -1053,7 +1053,7 @@ M;int;stap_parse_special_token;struct stap_parse_info *p;p # replace the register name from %ax to %eax. # # The rationale for this can be found at PR breakpoints/24541. -M;void;stap_adjust_register;struct stap_parse_info *p, std::string \®name, int regnum;p, regname, regnum +M;std::string;stap_adjust_register;struct stap_parse_info *p, const std::string \®name, int regnum;p, regname, regnum # DTrace related functions. |