diff options
author | Omair Javaid <omair.javaid@linaro.org> | 2018-05-26 05:58:51 +0500 |
---|---|---|
committer | Omair Javaid <omair.javaid@linaro.org> | 2018-05-31 07:31:21 +0500 |
commit | 5969f0dba74e17c694faf333b120f1e0b95783ed (patch) | |
tree | 5b1969d7d5c41099b6e0ec201fbad028b264b4f3 /gdb/gdbarch.sh | |
parent | 0034eed03a7428c4902244a33a286763bca65016 (diff) | |
download | binutils-gdb-5969f0dba74e17c694faf333b120f1e0b95783ed.tar.gz |
Unset gdbarch significant_addr_bit by default
This patch fixes a bug introduced by fix to AArch64 pointer tagging.
In our fix for tagged pointer support our agreed approach was to sign
extend user-space address after clearing tag bits. This is not same
for all architectures and this patch allows sign extension for
addresses on targets which specifically set significant_addr_bit.
More information about patch that caused the issues and discussion
around tagged pointer support can be found in links below:
https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html
https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html
gdb/ChangeLog:
2018-05-31 Omair Javaid <omair.javaid@linaro.org>
PR gdb/23210
* gdbarch.sh (significant_addr_bit): Default to zero when
not set by target architecture.
* gdbarch.c: Re-generated.
* utils.c (address_significant): Update.
Diffstat (limited to 'gdb/gdbarch.sh')
-rwxr-xr-x | gdb/gdbarch.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 73304309374..0a23b1ee0e7 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -622,7 +622,7 @@ m;CORE_ADDR;addr_bits_remove;CORE_ADDR addr;addr;;core_addr_identity;;0 # For example, on AArch64, the top bits of an address known as the "tag" # are ignored by the kernel, the hardware, etc. and can be regarded as # additional data associated with the address. -v;int;significant_addr_bit;;;;;gdbarch_addr_bit (gdbarch); +v;int;significant_addr_bit;;;;;;0 # FIXME/cagney/2001-01-18: This should be split in two. A target method that # indicates if the target needs software single step. An ISA method to |