diff options
| author | Pierre-Marie de Rodat <derodat@adacore.com> | 2015-09-01 16:18:40 +0200 |
|---|---|---|
| committer | Pierre-Marie de Rodat <derodat@adacore.com> | 2015-09-23 22:14:18 +0200 |
| commit | e6c2c623f7736175e52fce2b61aab60c60eccdf5 (patch) | |
| tree | 96702023fcb262163ec07db66506e92c3a8030a3 /gdb/ChangeLog | |
| parent | b6518b3871859f9eeb7653bf2f3baaa43fa0a5d0 (diff) | |
| download | binutils-gdb-e6c2c623f7736175e52fce2b61aab60c60eccdf5.tar.gz | |
[Ada] Fix handling of array renamings
Compilers can materialize renamings of arrays (or of accesses to arrays)
in Ada into variables whose types are references to the actual array
types. Before this change, trying to use such an array renaming yielded
an error in GDB:
(gdb) print my_array(1)
cannot subscript or call a record
(gdb) print my_array_ptr(1)
cannot subscript or call something of type `(null)'
This behavior comes from bad handling for array renamings, in particular
the OP_FUNCALL expression operator handling from ada-lang.c
(ada_evaluate_subexp): in one place we turn the reference into a
pointer, but the code that follows expect the value to be an array.
This patch fixes how we handle references in call/subscript evaluation
so that we turn these references into the actual array values instead of
pointers to them.
gdb/ChangeLog:
* ada-lang.c (ada_evaluate_subexp) <OP_FUNCALL>: When the input
value is a reference, actually dereference it in order to get
the underlying value.
gdb/testsuite/ChangeLog:
* gdb.ada/array_ptr_renaming.exp: New testcase.
* gdb.ada/array_ptr_renaming/foo.adb: New file.
* gdb.ada/array_ptr_renaming/pack.ads: New file.
Tested on x86_64-linux, no regression.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 42ffaf7b869..4c2750ad28f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2015-09-23 Pierre-Marie de Rodat <derodat@adacore.com> + + * ada-lang.c (ada_evaluate_subexp) <OP_FUNCALL>: When the input + value is a reference, actually dereference it in order to get + the underlying value. + 2015-09-22 Simon Marchi <simon.marchi@ericsson.com> * stap-probe.c (handle_stap_probe): Remove unnecessary cast. |