diff options
| author | Alan Modra <amodra@gmail.com> | 2017-12-15 17:08:56 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2017-12-19 06:51:33 +1030 |
| commit | f795c49463234dc347ddd9a1b07ee5b506295b96 (patch) | |
| tree | e55a82360d64a55d45ed88ade2d1e9c4438ac470 /binutils/testsuite/binutils-all/objdump.exp | |
| parent | c54207d32681bb205c28facba73b6173ef15eabf (diff) | |
| download | binutils-gdb-f795c49463234dc347ddd9a1b07ee5b506295b96.tar.gz | |
Test binutils_assemble return value
This is a followup to "binutils nm testsuite tidy". Since the perror
in binutils_assemble has been removed, we need to take more care in
failure paths.
The patch also fixed a number of .exp files that have multiple tests,
where an assembly failure returns from the .exp file. In most cases
it is nicer to attempt all tests.
* testsuite/binutils-all/ar.exp (unique_symbol): Don't run AR
if assembly fails.
* testsuite/binutils-all/arc/objdump.exp (check_assembly): If
objfile is empty, fail test.
* testsuite/binutils-all/arm/objdump.exp: Don't return if assembly
fails for a test, continue on to other tests.
* testsuite/binutils-all/bfin/objdump.exp: Likewise.
* testsuite/binutils-all/hppa/objdump.exp: Likewise.
* testsuite/binutils-all/m68k/objdump.exp: Likewise.
* testsuite/binutils-all/vax/objdump.exp: Likewise.
* testsuite/binutils-all/size.exp: Likewise.
* testsuite/binutils-all/nm.exp: Likewise. Move PR12753 test.
* testsuite/binutils-all/objcopy.exp: Don't perror on assembly fail.
* testsuite/binutils-all/objdump.exp: Report assembly fails.
Diffstat (limited to 'binutils/testsuite/binutils-all/objdump.exp')
| -rw-r--r-- | binutils/testsuite/binutils-all/objdump.exp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp index 8ee350ff890..e780bb5fa9f 100644 --- a/binutils/testsuite/binutils-all/objdump.exp +++ b/binutils/testsuite/binutils-all/objdump.exp @@ -62,9 +62,11 @@ if [regexp $want $got] then { if {![binutils_assemble $srcdir/$subdir/bintest.s tmpdir/bintest.o]} then { + fail "objdump (assembling)" return } if {![binutils_assemble $srcdir/$subdir/bintest.s tmpdir/bintest2.o]} then { + fail "objdump (assembling)" return } if [is_remote host] { |