diff options
| author | Alan Modra <amodra@gmail.com> | 2019-08-16 15:17:23 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2019-08-16 15:17:23 +0930 |
| commit | 0b8b76098ff3d3dcd0c621f2e45cc0b4e7211d6a (patch) | |
| tree | aa0c4a7a1f9bc16dfe1490c7cf5c79989417cf10 /binutils/readelf.c | |
| parent | 7df6aecc97b96843da080d54414052b1c954ddca (diff) | |
| download | binutils-gdb-0b8b76098ff3d3dcd0c621f2e45cc0b4e7211d6a.tar.gz | |
PR24909, Uninitialized use on stack in readelf
PR 24909
PR 23499
* readelf.c (get_symbol_version_string): Set sym_info earlier.
Diffstat (limited to 'binutils/readelf.c')
| -rw-r--r-- | binutils/readelf.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/binutils/readelf.c b/binutils/readelf.c index b90d3bc885c..cc168163b21 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -11528,6 +11528,7 @@ get_symbol_version_string (Filedata * filedata, if ((vers_data & VERSYM_HIDDEN) == 0 && vers_data == 0) return NULL; + *sym_info = (vers_data & VERSYM_HIDDEN) != 0 ? symbol_hidden : symbol_public; max_vd_ndx = 0; /* Usually we'd only see verdef for defined symbols, and verneed for @@ -11593,12 +11594,8 @@ get_symbol_version_string (Filedata * filedata, ivda.vda_name = BYTE_GET (evda.vda_name); if (psym->st_name != ivda.vda_name) - { - *sym_info = ((vers_data & VERSYM_HIDDEN) != 0 - ? symbol_hidden : symbol_public); - return (ivda.vda_name < strtab_size - ? strtab + ivda.vda_name : _("<corrupt>")); - } + return (ivda.vda_name < strtab_size + ? strtab + ivda.vda_name : _("<corrupt>")); } } } |