summaryrefslogtreecommitdiff
path: root/binutils/readelf.c
diff options
context:
space:
mode:
authorYuriy M. Kaminskiy <yumkam@gmail.com>2015-08-04 16:51:53 +0100
committerNick Clifton <nickc@redhat.com>2015-08-04 16:51:53 +0100
commit7e27a9d5f22f9f7ead11738b1546d0b5c737266b (patch)
tree46bffdfecd821e8f439790cab4da495658777807 /binutils/readelf.c
parent4e13f8fb05eb7ffd163d96e519cc011d8d21e3d7 (diff)
downloadbinutils-gdb-7e27a9d5f22f9f7ead11738b1546d0b5c737266b.tar.gz
Fix stack buffer overflows when parsing corrupt ihex files.
PR binutils/18750 * ihex.c (ihex_scan): Fixes incorrect escape sequence in error message and stack overflow when char is signed and \200-\376 was in place of hex digit; also fixes \377 was handled as EOF instead of "incorrect character". (ihex_read_section): Changed for consistency. (ihex_bad_byte): Prevent (now impossible to trigger) stack overflow and incorrect escape sequence handling. * srec.c (srec_bad_byte): Likewise. * readelf.c (process_mips_specific): Fix incorrect escape sequence handling.
Diffstat (limited to 'binutils/readelf.c')
-rw-r--r--binutils/readelf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/binutils/readelf.c b/binutils/readelf.c
index a9b9f2dbbd2..6298f1e29d8 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -14467,7 +14467,7 @@ process_mips_specific (FILE * file)
len = sizeof (* eopt);
while (len < option->size)
{
- char datum = * ((char *) eopt + offset + len);
+ unsigned char datum = * ((unsigned char *) eopt + offset + len);
if (ISPRINT (datum))
printf ("%c", datum);