summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLewis Revill <lewis.revill@embecosm.com>2021-10-22 11:32:46 +0800
committerNelson Chu <nelson.chu@sifive.com>2021-10-22 16:44:43 +0800
commitc628f812eba820e11ef83033b38becca1b148dc5 (patch)
tree12eda3d5fda0a27c206bf9afda4010c2282f72aa
parent9abcdc10b21ed9f98e218ead7ac9d91612f9ed0f (diff)
downloadbinutils-gdb-c628f812eba820e11ef83033b38becca1b148dc5.tar.gz
RISC-V: Added ld testcase for pcgp relaxation.
Consider the the pcgp-relax-02 testcase, .text .globl _start _start: .L1: auipc a0, %pcrel_hi(data_a) .L2: auipc a1, %pcrel_hi(data_b) addi a0, a0, %pcrel_lo(.L1) addi a1, a1, %pcrel_lo(.L2) .data .word 0x0 .globl data_a data_a: .word 0x1 .section .rodata .globl data_b data_b: .word 0x2 If the first auipc is deleted, but we are still building the pcgp table (connect the high and low pcrel relocations), then there is an aliasing issue that we need some way to disambiguate which of the two symbols we are targeting. Therefore, Palmer thought of a way to use R_RISCV_DELETE to split this into two phases, so we could resolve the addresses before creating the ambiguities. This patch just add the ld testcase for the above case, in case we have changed something but break this. ld/ * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Renamed pcgp-relax to pcgp-relax-01, and added pcgp-relax-02. * testsuite/ld-riscv-elf/pcgp-relax-01.d: Renmaed from pcgp-relax. * testsuite/ld-riscv-elf/pcgp-relax-01.s: Likewise. * testsuite/ld-riscv-elf/pcgp-relax-02.d: New testcase. * testsuite/ld-riscv-elf/pcgp-relax-02.s: Likewise.
-rw-r--r--ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp3
-rw-r--r--ld/testsuite/ld-riscv-elf/pcgp-relax-01.d (renamed from ld/testsuite/ld-riscv-elf/pcgp-relax.d)2
-rw-r--r--ld/testsuite/ld-riscv-elf/pcgp-relax-01.s (renamed from ld/testsuite/ld-riscv-elf/pcgp-relax.s)0
-rw-r--r--ld/testsuite/ld-riscv-elf/pcgp-relax-02.d15
-rw-r--r--ld/testsuite/ld-riscv-elf/pcgp-relax-02.s18
5 files changed, 36 insertions, 2 deletions
diff --git a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
index 20ca3bdb195..78a71345bf2 100644
--- a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
+++ b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
@@ -121,7 +121,8 @@ proc run_relax_twice_test {} {
if [istarget "riscv*-*-*"] {
run_dump_test "align-small-region"
run_dump_test "call-relax"
- run_dump_test "pcgp-relax"
+ run_dump_test "pcgp-relax-01"
+ run_dump_test "pcgp-relax-02"
run_dump_test "c-lui"
run_dump_test "c-lui-2"
run_dump_test "disas-jalr"
diff --git a/ld/testsuite/ld-riscv-elf/pcgp-relax.d b/ld/testsuite/ld-riscv-elf/pcgp-relax-01.d
index dae2b62b9a7..f9425678559 100644
--- a/ld/testsuite/ld-riscv-elf/pcgp-relax.d
+++ b/ld/testsuite/ld-riscv-elf/pcgp-relax-01.d
@@ -1,4 +1,4 @@
-#source: pcgp-relax.s
+#source: pcgp-relax-01.s
#ld: --relax
#objdump: -d -Mno-aliases
diff --git a/ld/testsuite/ld-riscv-elf/pcgp-relax.s b/ld/testsuite/ld-riscv-elf/pcgp-relax-01.s
index fab6a5bf140..fab6a5bf140 100644
--- a/ld/testsuite/ld-riscv-elf/pcgp-relax.s
+++ b/ld/testsuite/ld-riscv-elf/pcgp-relax-01.s
diff --git a/ld/testsuite/ld-riscv-elf/pcgp-relax-02.d b/ld/testsuite/ld-riscv-elf/pcgp-relax-02.d
new file mode 100644
index 00000000000..c6c73c54265
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/pcgp-relax-02.d
@@ -0,0 +1,15 @@
+#source: pcgp-relax-02.s
+#as:
+#ld: --relax
+#objdump: -d
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+[0-9a-f]+ <_start>:
+.*:[ ]+[0-9a-f]+[ ]+auipc[ ]+a1.*
+.*:[ ]+[0-9a-f]+[ ]+addi[ ]+a0,gp.*<data_a>
+.*:[ ]+[0-9a-f]+[ ]+addi[ ]+a1,a1.*<data_b>
+#pass
diff --git a/ld/testsuite/ld-riscv-elf/pcgp-relax-02.s b/ld/testsuite/ld-riscv-elf/pcgp-relax-02.s
new file mode 100644
index 00000000000..ca4aa1fa9d2
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/pcgp-relax-02.s
@@ -0,0 +1,18 @@
+ .text
+ .globl _start
+_start:
+.L1: auipc a0, %pcrel_hi(data_a)
+.L2: auipc a1, %pcrel_hi(data_b)
+ addi a0, a0, %pcrel_lo(.L1)
+ addi a1, a1, %pcrel_lo(.L2)
+
+ .data
+ .word 0x0
+ .globl data_a
+data_a:
+ .word 0x1
+
+ .section .rodata
+ .globl data_b
+data_b:
+ .word 0x2