summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@efficios.com>2020-05-07 11:41:45 -0400
committerSimon Marchi <simon.marchi@efficios.com>2020-05-07 11:41:58 -0400
commita1b68f2834dac97611e09b8b751ba68a78c3c467 (patch)
tree55a1e33f75f2e26d25fdf50be475c967298817a8
parent98d48915d987c577c34e5516040ab04c0dab6baa (diff)
downloadbinutils-gdb-a1b68f2834dac97611e09b8b751ba68a78c3c467.tar.gz
gdb: small cleanup of async-event.c structs
This is a small cleanup to normalize the structures in async-event.c with the rest of the code base: - Remove the unnecessary typedefs - Fix indentation of struct bodies - Put comments above fields No functional changes expected. gdb/ChangeLog: * async-event.c (struct async_signal_handler, struct async_event_handler): Reformat, remove typedef.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/async-event.c74
2 files changed, 44 insertions, 35 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b7c2c4b0849..d287d3aa5e9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2020-05-07 Simon Marchi <simon.marchi@efficios.com>
+ * async-event.c (struct async_signal_handler, struct
+ async_event_handler): Reformat, remove typedef.
+
+2020-05-07 Simon Marchi <simon.marchi@efficios.com>
+
* gdbtypes.h (TYPE_DYN_PROP_LIST): Remove. Update all users
access thistype->main_type->dyn_prop_list directly.
diff --git a/gdb/async-event.c b/gdb/async-event.c
index dd65c17468b..4354175edfa 100644
--- a/gdb/async-event.c
+++ b/gdb/async-event.c
@@ -32,16 +32,21 @@
Async_init_signals takes care of setting up such an
async_signal_handler for each interesting signal. */
-typedef struct async_signal_handler
- {
- int ready; /* If ready, call this handler
- from the main event loop, using
- invoke_async_handler. */
- struct async_signal_handler *next_handler; /* Ptr to next handler. */
- sig_handler_func *proc; /* Function to call to do the work. */
- gdb_client_data client_data; /* Argument to async_handler_func. */
- }
-async_signal_handler;
+struct async_signal_handler
+{
+ /* If ready, call this handler from the main event loop, using
+ invoke_async_handler. */
+ int ready;
+
+ /* Pointer to next handler. */
+ struct async_signal_handler *next_handler;
+
+ /* Function to call to do the work. */
+ sig_handler_func *proc;
+
+ /* Argument to PROC. */
+ gdb_client_data client_data;
+};
/* PROC is a function to be invoked when the READY flag is set. This
happens when the event has been marked with
@@ -49,45 +54,44 @@ async_signal_handler;
to an event will be carried out by PROC at a later time, within
process_event. This provides a deferred execution of event
handlers. */
-typedef struct async_event_handler
- {
- /* If ready, call this handler from the main event loop, using
- invoke_event_handler. */
- int ready;
+struct async_event_handler
+{
+ /* If ready, call this handler from the main event loop, using
+ invoke_event_handler. */
+ int ready;
- /* Point to next handler. */
- struct async_event_handler *next_handler;
+ /* Pointer to next handler. */
+ struct async_event_handler *next_handler;
- /* Function to call to do the work. */
- async_event_handler_func *proc;
+ /* Function to call to do the work. */
+ async_event_handler_func *proc;
- /* Argument to PROC. */
- gdb_client_data client_data;
- }
-async_event_handler;
+ /* Argument to PROC. */
+ gdb_client_data client_data;
+};
/* All the async_signal_handlers gdb is interested in are kept onto
this list. */
static struct
- {
- /* Pointer to first in handler list. */
- async_signal_handler *first_handler;
+{
+ /* Pointer to first in handler list. */
+ async_signal_handler *first_handler;
- /* Pointer to last in handler list. */
- async_signal_handler *last_handler;
- }
+ /* Pointer to last in handler list. */
+ async_signal_handler *last_handler;
+}
sighandler_list;
/* All the async_event_handlers gdb is interested in are kept onto
this list. */
static struct
- {
- /* Pointer to first in handler list. */
- async_event_handler *first_handler;
+{
+ /* Pointer to first in handler list. */
+ async_event_handler *first_handler;
- /* Pointer to last in handler list. */
- async_event_handler *last_handler;
- }
+ /* Pointer to last in handler list. */
+ async_event_handler *last_handler;
+}
async_event_handler_list;