diff options
| author | Alan Modra <amodra@gmail.com> | 2021-02-04 13:56:34 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-02-04 16:51:31 +1030 |
| commit | b71c7a5814298708d9574c9e0a56455f3a860e14 (patch) | |
| tree | a8899da54a29145f02265613793cd4c6803109ea | |
| parent | 401fafe1923f8fb5c79cae5abe5e70db4031f183 (diff) | |
| download | binutils-gdb-b71c7a5814298708d9574c9e0a56455f3a860e14.tar.gz | |
PR27311, (symbol from plugin): undefined reference, hidden sym
bfd/
PR 27311
* elflink.c (elf_link_add_object_symbols): Don't pull in as-needed
libraries for IR references on pass over libraries after LTO
recompilation.
ld/
* testsuite/ld-plugin/pr27311d.c: New test.
* testsuite/ld-plugin/lto.exp: Rename pr27311 to pr27311-1, compile
and link new test as pr27311-2.
(cherry picked from commit 7d409ac001cce916661d345bff01ed589991e762)
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/elflink.c | 1 | ||||
| -rw-r--r-- | ld/ChangeLog | 6 | ||||
| -rw-r--r-- | ld/testsuite/ld-plugin/lto.exp | 10 | ||||
| -rw-r--r-- | ld/testsuite/ld-plugin/pr27311d.c | 5 |
5 files changed, 27 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index e2a34164f69..c5cbad5d881 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2021-02-04 Alan Modra <amodra@gmail.com> + + PR 27311 + * elflink.c (elf_link_add_object_symbols): Don't pull in as-needed + libraries for IR references on pass over libraries after LTO + recompilation. + 2021-02-03 Alan Modra <amodra@gmail.com> PR 27311 diff --git a/bfd/elflink.c b/bfd/elflink.c index da288f3f2ac..7afbc5b1072 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -5279,6 +5279,7 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info) && h->ref_regular_nonweak) || (old_bfd != NULL && (old_bfd->flags & BFD_PLUGIN) != 0 + && !info->lto_all_symbols_read && bind != STB_WEAK) || (h->ref_dynamic_nonweak && (elf_dyn_lib_class (abfd) & DYN_AS_NEEDED) != 0 diff --git a/ld/ChangeLog b/ld/ChangeLog index fbb7d5094f2..c299fb15867 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,9 @@ +2021-02-04 Alan Modra <amodra@gmail.com> + + * testsuite/ld-plugin/pr27311d.c: New test. + * testsuite/ld-plugin/lto.exp: Rename pr27311 to pr27311-1, compile + and link new test as pr27311-2. + 2021-02-03 Alan Modra <amodra@gmail.com> Apply from mainline diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp index 878d9e776ae..3a59e37bc92 100644 --- a/ld/testsuite/ld-plugin/lto.exp +++ b/ld/testsuite/ld-plugin/lto.exp @@ -424,9 +424,15 @@ set lto_link_elf_tests [list \ [list {pr27311c.o} \ {} {-flto} \ {pr27311c.c} {} {} {c}] \ - [list {pr27311} \ + [list {pr27311d.o} \ + {} {-flto} \ + {pr27311d.c} {} {} {c}] \ + [list {pr27311-1} \ {tmpdir/pr27311c.o -Wl,--no-as-needed,--rpath-link=. tmpdir/pr27311b.so} {} \ - {dummy.c} {{readelf {--dyn-syms --wide} pr27311.d}} {pr27311}] \ + {dummy.c} {{readelf {--dyn-syms --wide} pr27311.d}} {pr27311-1}] \ + [list {pr27311-2} \ + {tmpdir/pr27311d.o -Wl,--no-as-needed,--rpath-link=. tmpdir/pr27311b.so} {} \ + {dummy.c} {{readelf {--dyn-syms --wide} pr27311.d}} {pr27311-2}] \ ] # PR 14918 checks that libgcc is not spuriously included in a shared link of diff --git a/ld/testsuite/ld-plugin/pr27311d.c b/ld/testsuite/ld-plugin/pr27311d.c new file mode 100644 index 00000000000..11e4ba4d6dd --- /dev/null +++ b/ld/testsuite/ld-plugin/pr27311d.c @@ -0,0 +1,5 @@ +__attribute__((visibility("hidden"))) void inlib1(void) {} +int main() +{ + return 0; +} |