summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2017-10-10 15:10:25 -0400
committerSimon Marchi <simon.marchi@ericsson.com>2017-10-10 15:10:25 -0400
commit2f20e312aad64c0f5257b9725fa5ffa3e8a93ca2 (patch)
treed9b661d29337cf0e0c2c68638f41dde6806c40eb
parenteb8c0d308be8525f7c25962a9c581f44af23a364 (diff)
downloadbinutils-gdb-2f20e312aad64c0f5257b9725fa5ffa3e8a93ca2.tar.gz
get_integer_valueof: Don't output value in test name
The get_integer_valueof outputs the value it has read as part of the test name. This causes test names to vary from run to run, and adds some noise when diffing test results. e.g.: -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (28770) +PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (32238) This patch removes that, since it's probably not very useful. gdb/testsuite/ChangeLog: * lib/gdb.exp (get_integer_valueof): Don't output read value in test name.
-rw-r--r--gdb/testsuite/ChangeLog4
-rw-r--r--gdb/testsuite/lib/gdb.exp2
2 files changed, 5 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4ad0c02992a..dd0645c80fc 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2017-10-10 Simon Marchi <simon.marchi@ericsson.com>
+
+ * lib/gdb.exp (get_integer_valueof): Don't output read value in test name.
+
2017-10-10 Pedro Alves <palves@redhat.com>
* gdb.mi/mi-pthreads.exp (check_mi_thread_command_set): Don't
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 48fec2f56b9..9d8296a109e 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5634,7 +5634,7 @@ proc get_integer_valueof { exp default {test ""} } {
gdb_test_multiple "print /d ${exp}" "$test" {
-re "\\$\[0-9\]* = (\[-\]*\[0-9\]*).*$gdb_prompt $" {
set val $expect_out(1,string)
- pass "$test ($val)"
+ pass "$test"
}
timeout {
fail "$test (timeout)"