diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2015-07-24 14:58:35 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2015-07-26 15:16:54 -0700 |
| commit | 14579788abd184bf6d6a8bd97e33342e65e9fd85 (patch) | |
| tree | d855e28b9b3853a8d2f63f9a77e66c1c2fad49a5 | |
| parent | 36f47dd224ee81ef31806f5288f2c4bafd0b6bd8 (diff) | |
| download | binutils-gdb-14579788abd184bf6d6a8bd97e33342e65e9fd85.tar.gz | |
Pass $PLT_CFLAGS to ld_compile
Some linker visibility tests without PIC expect PLT. This patch passes
$PLT_CFLAGS to ld_compile.
* ld-elfvsb/elfvsb.exp (visibility_run): Pass $PLT_CFLAGS to
ld_compile.
| -rw-r--r-- | ld/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | ld/testsuite/ld-elfvsb/elfvsb.exp | 12 |
2 files changed, 12 insertions, 5 deletions
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog index c77381ef198..cea6ccb124a 100644 --- a/ld/testsuite/ChangeLog +++ b/ld/testsuite/ChangeLog @@ -22,6 +22,11 @@ 2015-07-24 H.J. Lu <hongjiu.lu@intel.com> + * ld-elfvsb/elfvsb.exp (visibility_run): Pass $PLT_CFLAGS to + ld_compile. + +2015-07-24 H.J. Lu <hongjiu.lu@intel.com> + * ld-elfvers/vers.exp (build_vers_lib_no_pic): Pass $PLT_CFLAGS to build_binary. diff --git a/ld/testsuite/ld-elfvsb/elfvsb.exp b/ld/testsuite/ld-elfvsb/elfvsb.exp index 8ae8c3d934d..e02d4faeee2 100644 --- a/ld/testsuite/ld-elfvsb/elfvsb.exp +++ b/ld/testsuite/ld-elfvsb/elfvsb.exp @@ -227,6 +227,7 @@ proc visibility_run {visibility} { global target_triplet global support_protected global shared_needs_pic + global PLT_CFLAGS if [ string match $visibility "hidden" ] { set VSBCFLAG "-DHIDDEN_TEST" @@ -259,8 +260,9 @@ proc visibility_run {visibility} { # functions and variables not being overridable. Newer versions # of gcc are more likely to do this. } else { - # Compile the main program. - if ![ld_compile "$CC -g $CFLAGS $SHCFLAG $VSBCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o] { + # Compile the main program. Make sure that PLT is used since PLT + # is expected. + if ![ld_compile "$CC -g $PLT_CFLAGS $CFLAGS $SHCFLAG $VSBCFLAG" $srcdir/$subdir/main.c $tmpdir/mainnp.o] { unresolved "visibility ($visibility) (non PIC)" unresolved "visibility ($visibility)" } else { @@ -269,9 +271,9 @@ proc visibility_run {visibility} { # although it will be less efficient because the dynamic linker # will need to do more relocation work. However, note that not # using -fpic will cause some of the tests to return different - # results. - if { ![ld_compile "$CC -g $CFLAGS $SHCFLAG $VSBCFLAG" $srcdir/$subdir/sh1.c $tmpdir/sh1np.o] - || ![ld_compile "$CC -g $CFLAGS $SHCFLAG $VSBCFLAG" $srcdir/$subdir/sh2.c $tmpdir/sh2np.o] } { + # results. Make sure that PLT is used since PLT is expected. + if { ![ld_compile "$CC -g $PLT_CFLAGS $CFLAGS $SHCFLAG $VSBCFLAG" $srcdir/$subdir/sh1.c $tmpdir/sh1np.o] + || ![ld_compile "$CC -g $PLT_CFLAGS $CFLAGS $SHCFLAG $VSBCFLAG" $srcdir/$subdir/sh2.c $tmpdir/sh2np.o] } { unresolved "visibility ($visibility) (non PIC)" } else { if { [istarget rs6000*-*-aix*] || [istarget powerpc*-*-aix*] } { visibility_test $visibility vnp "visibility ($visibility) (non PIC)" mainnp.o sh1np.o sh2np.o xcoff |