diff options
| author | Alan Modra <amodra@gmail.com> | 2019-12-10 17:57:14 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2019-12-11 11:33:36 +1030 |
| commit | 8ff23dba80b80a9f47d75dd43812e041f6674763 (patch) | |
| tree | 3a1573a8384edf7039c1a96db2565f4ff04c9c6d | |
| parent | d1f80fe061d11d825fc3a6afc5200f090d1aed0f (diff) | |
| download | binutils-gdb-8ff23dba80b80a9f47d75dd43812e041f6674763.tar.gz | |
ubsan: ia64: left shift of negative value
Here, since val is signed:
*valuep = (val << scale);
* cpu-ia64-opc.c (ext_imms_scaled): Avoid undefined left shift
of negative values by using unsigned vars.
| -rw-r--r-- | bfd/ChangeLog | 5 | ||||
| -rw-r--r-- | bfd/cpu-ia64-opc.c | 6 |
2 files changed, 8 insertions, 3 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 50c878b29df..17ad44160a4 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2019-12-11 Alan Modra <amodra@gmail.com> + + * cpu-ia64-opc.c (ext_imms_scaled): Avoid undefined left shift + of negative values by using unsigned vars. + 2019-12-07 Alan Modra <amodra@gmail.com> PR 25236 diff --git a/bfd/cpu-ia64-opc.c b/bfd/cpu-ia64-opc.c index 84ee0e2e4a9..8df90befe39 100644 --- a/bfd/cpu-ia64-opc.c +++ b/bfd/cpu-ia64-opc.c @@ -186,7 +186,7 @@ ext_imms_scaled (const struct ia64_operand *self, ia64_insn code, ia64_insn *valuep, int scale) { int i, bits = 0, total = 0; - BFD_HOST_64_BIT val = 0, sign; + BFD_HOST_U_64_BIT val = 0, sign; for (i = 0; i < NELEMS (self->field) && self->field[i].bits; ++i) { @@ -196,10 +196,10 @@ ext_imms_scaled (const struct ia64_operand *self, ia64_insn code, total += bits; } /* sign extend: */ - sign = (BFD_HOST_64_BIT) 1 << (total - 1); + sign = (BFD_HOST_U_64_BIT) 1 << (total - 1); val = (val ^ sign) - sign; - *valuep = (val << scale); + *valuep = val << scale; return 0; } |