summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-04-22 10:46:03 -0600
committerTom Tromey <tom@tromey.com>2018-10-04 22:51:48 -0600
commitd951f98b3c8bf202571327d8679ae30ca1da9fdc (patch)
treecdcd3063a1006985782dcf79db15423c61949e31
parentb8c888478d517a39d8b0104857d573e47620a3d1 (diff)
downloadbinutils-gdb-d951f98b3c8bf202571327d8679ae30ca1da9fdc.tar.gz
Shadowing fix in gdbscm_frame_read_var
-Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var means that the ultimate call to read_var_value will always be passed block==NULL. The fix is to remove the inner declaration. gdb/ChangeLog 2018-10-04 Tom Tromey <tom@tromey.com> * guile/scm-frame.c (gdbscm_frame_read_var): Remove inner declaration of "block".
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/guile/scm-frame.c1
2 files changed, 5 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 42c55edf4c8..3bf08bcb4b0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2018-10-04 Tom Tromey <tom@tromey.com>
+ * guile/scm-frame.c (gdbscm_frame_read_var): Remove inner
+ declaration of "block".
+
+2018-10-04 Tom Tromey <tom@tromey.com>
+
* common/filestuff.c (fdwalk): Remove inner declaration of
"result".
diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
index 3d27907e193..5a056de3328 100644
--- a/gdb/guile/scm-frame.c
+++ b/gdb/guile/scm-frame.c
@@ -878,7 +878,6 @@ gdbscm_frame_read_var (SCM self, SCM symbol_scm, SCM rest)
}
else if (scm_is_string (symbol_scm))
{
- const struct block *block = NULL;
struct gdb_exception except = exception_none;
if (! SCM_UNBNDP (block_scm))