diff options
| author | Pedro Alves <palves@redhat.com> | 2014-03-21 11:08:44 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2014-03-21 11:08:44 +0000 |
| commit | b65dc60b233704405c334bbe16c4fc5689187b7b (patch) | |
| tree | dc93aea4b22b2d5552a04dd495e34dddfa586706 | |
| parent | 36cb1214c9f26b4e9b42d146dcf64621b36b91df (diff) | |
| download | binutils-gdb-b65dc60b233704405c334bbe16c4fc5689187b7b.tar.gz | |
normal_stop: Extend and clarify comment.
Explain better why we skip saying "Switching to ..." in non-stop mode.
gdb/
2014-03-21 Pedro Alves <palves@redhat.com>
* infrun.c (normal_stop): Extend comment.
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/infrun.c | 16 |
2 files changed, 14 insertions, 6 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ba2ca31f3ce..0aec7b92304 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-03-21 Pedro Alves <palves@redhat.com> + + * infrun.c (normal_stop): Extend comment. + 2014-03-21 Hui Zhu <hui@codesourcery.com> Pedro Alves <palves@redhat.com> diff --git a/gdb/infrun.c b/gdb/infrun.c index d7de7d16339..8f9e820735a 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -6059,18 +6059,22 @@ normal_stop (void) && last.kind != TARGET_WAITKIND_NO_RESUMED) make_cleanup (finish_thread_state_cleanup, &inferior_ptid); - /* In non-stop mode, we don't want GDB to switch threads behind the - user's back, to avoid races where the user is typing a command to - apply to thread x, but GDB switches to thread y before the user - finishes entering the command. */ - /* As with the notification of thread events, we want to delay notifying the user that we've switched thread context until the inferior actually stops. There's no point in saying anything if the inferior has exited. Note that SIGNALLED here means "exited with a signal", not - "received a signal". */ + "received a signal". + + Also skip saying anything in non-stop mode. In that mode, as we + don't want GDB to switch threads behind the user's back, to avoid + races where the user is typing a command to apply to thread x, + but GDB switches to thread y before the user finishes entering + the command, fetch_inferior_event installs a cleanup to restore + the current thread back to the thread the user had selected right + after this event is handled, so we're not really switching, only + informing of a stop. */ if (!non_stop && !ptid_equal (previous_inferior_ptid, inferior_ptid) && target_has_execution |