Fix missing lock when GC_generate_random_valid_address is called

(a cherry-pick of commit 0c6b4caa1 from 'release-8_2')

Issue #414 (bdwgc).

* dbg_mlc.c [KEEP_BACK_PTRS] (GC_generate_random_backtrace_no_gc):
Wrap GC_generate_random_valid_address() call into LOCK/UNLOCK.
* finalize.c [KEEP_BACK_PTRS] (GC_notify_or_invoke_finalizers):
Declare current local variable; expand
GC_generate_random_backtrace_no_gc() manually.
* finalize.c [KEEP_BACK_PTRS] (GC_notify_or_invoke_finalizers):
UNLOCK after GC_generate_random_valid_address() call.
* include/private/gc_priv.h [KEEP_BACK_PTRS]
(GC_generate_random_backtrace_no_gc): Remove declaration.

1 files changed, 4 insertions, 0 deletions

diff --git a/dbg_mlc.c b/dbg_mlc.c
index 487c029f..32fc4652 100644
--- a/dbg_mlc.c
+++ b/dbg_mlc.c
@@ -252,7 +252,11 @@
   GC_INNER void GC_generate_random_backtrace_no_gc(void)
   {
     void * current;
+    DCL_LOCK_STATE;
+
+    LOCK();
     current = GC_generate_random_valid_address();
+    UNLOCK();
     GC_printf("\n****Chosen address %p in object\n", current);
     GC_print_backtrace(current);
   }