summaryrefslogtreecommitdiff
path: root/contrib/cksfv
diff options
context:
space:
mode:
authorFreddy Vulto <fvulto@gmail.com>2009-09-25 09:36:29 +0200
committerFreddy Vulto <fvulto@gmail.com>2009-09-25 09:36:29 +0200
commitcfcf9fae8fbd79350829b2917f9fa40a32beb7d9 (patch)
tree16f28ae19e647ffdc303e088d71754ddd845b9c0 /contrib/cksfv
parentf871fe4101ed89cb98e201aed8c975fd3061905b (diff)
downloadbash-completion-cfcf9fae8fbd79350829b2917f9fa40a32beb7d9.tar.gz
Quote unquoted $cur to prevent globbing.
Closes Alioth #311614 Globbing might occur if $cur contains one of these globbing characters: * ? [ ] The bug becomes apparent: On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7): MS-DOS style path detected: ... Preferred POSIX equivalent is: ... CYGWIN environment variable option "nodosfilewarning" turns off this warning. Consult the user's guide for more details about POSIX paths: http://cygwin.com/cygwin-ug-net/using.html#using-pathnames On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call. Steps to reproduce on Linux using `strace': Environment: Linux, bash-completion-1.0 1. Start bash with bash-completion loaded and find out PID ($$): $ echo $$ MYPID 2. In a second bash shell, `strace' the above PID: $ strace -e trace=open -f -o strace.log -p MYPID 3. Within the first bash shell, type: $ cur="?"; _kernel_versions 4. In the second bash shell, type ^C to quick `strace'. 5. Check `strace.log', here you can see bash accessing something it shouldn't: ... open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3 ... 6. The above call to `open' disappears if $cur in _kernel_versions gets quoted, and you repeat the steps above: _kernel_versions() { COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) ) }
Diffstat (limited to 'contrib/cksfv')
-rw-r--r--contrib/cksfv2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/cksfv b/contrib/cksfv
index b8758709..2b1d55f6 100644
--- a/contrib/cksfv
+++ b/contrib/cksfv
@@ -10,7 +10,7 @@ _cksfv()
cur=`_get_cword`
if [ $COMP_CWORD -eq 1 ]; then
- COMPREPLY=( $( compgen -W '-C -f -i -q -v' -- $cur ) )
+ COMPREPLY=( $( compgen -W '-C -f -i -q -v' -- "$cur" ) )
return 0
fi