summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVille Skyttä <ville.skytta@iki.fi>2010-01-24 19:36:10 +0200
committerVille Skyttä <ville.skytta@iki.fi>2010-01-24 19:36:10 +0200
commit5c5d804696ad715c4d8516b061564d0ab5115ab6 (patch)
treebefc2c9d4ed2dd41e462f5c850d1b206d2f3dc4a
parentc5951118e906c8937312ff4605a9f47a9cfd108f (diff)
downloadbash-completion-5c5d804696ad715c4d8516b061564d0ab5115ab6.tar.gz
Update patch submission guidelines.
-rw-r--r--README14
1 files changed, 9 insertions, 5 deletions
diff --git a/README b/README
index e48b5556..4ee9a4ea 100644
--- a/README
+++ b/README
@@ -396,11 +396,15 @@ guidelines in mind:
create race conditions, is inefficient, violates the principle of
least surprise and lacks robustness.
-- Send your patches as unified diffs. You can make these with
- 'diff -u'.
-
-- Send small, incremental diffs that affect a single function. Don't
- cram massive, unrelated patches into a single diff.
+- Send small, incremental diffs that do one thing. Don't cram unrelated
+ changes into a single diff.
+
+- Generate patches preferably against the git repository, with "git
+ format-patch origin/master" (assuming the diff was against the
+ origin/master branch), and don't forget the entry for the CHANGES file
+ if you feel that the change deserves one. If you don't have git
+ available or can't access the repository for some reason, generate
+ patches as unified diffs ('diff -u').
- If your code was written for a particular platform, try to make it
portable to other platforms, so that everyone may enjoy it. If your