summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVille Skyttä <ville.skytta@iki.fi>2011-01-17 22:14:18 +0200
committerVille Skyttä <ville.skytta@iki.fi>2011-01-17 22:14:18 +0200
commitd6043b960990e7f55cc23d4c9fce2943de92d046 (patch)
treeb0b928b9fd4befe173fbfbb5819250aa26db44f5
parente99645d2b942b85b3020ee66004fd1b7a0cf6723 (diff)
downloadbash-completion-d6043b960990e7f55cc23d4c9fce2943de92d046.tar.gz
Don't leak $options from iscsiadm completion, add basic test case.
-rw-r--r--completions/open-iscsi1
-rw-r--r--test/completion/iscsiadm.exp1
-rw-r--r--test/lib/completions/iscsiadm.exp20
3 files changed, 22 insertions, 0 deletions
diff --git a/completions/open-iscsi b/completions/open-iscsi
index 0d138c71..8c650d59 100644
--- a/completions/open-iscsi
+++ b/completions/open-iscsi
@@ -32,6 +32,7 @@ _iscsiadm()
$split && return 0
+ local options
if [[ $COMP_CWORD -gt 1 ]] ; then
mode=${COMP_WORDS[2]}
diff --git a/test/completion/iscsiadm.exp b/test/completion/iscsiadm.exp
new file mode 100644
index 00000000..6d760dd4
--- /dev/null
+++ b/test/completion/iscsiadm.exp
@@ -0,0 +1 @@
+assert_source_completions iscsiadm
diff --git a/test/lib/completions/iscsiadm.exp b/test/lib/completions/iscsiadm.exp
new file mode 100644
index 00000000..104e7c4e
--- /dev/null
+++ b/test/lib/completions/iscsiadm.exp
@@ -0,0 +1,20 @@
+proc setup {} {
+ save_env
+}
+
+
+proc teardown {} {
+ assert_env_unmodified
+}
+
+
+setup
+
+
+assert_complete_any "iscsiadm --mode "
+
+
+sync_after_int
+
+
+teardown