summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevron Rees <kevron.m.rees@intel.com>2013-12-10 11:10:03 -0800
committerKevron Rees <kevron.m.rees@intel.com>2013-12-10 11:10:03 -0800
commita1fb86ee2f666bf45627b48d3221c85f88cca0b5 (patch)
treeccc839dd25ecd8fa606bb5a7ca5ba54e5e3b60f7
parent76429bb043d228ef1e6c1dcb4f708baf6750f173 (diff)
downloadautomotive-message-broker-a1fb86ee2f666bf45627b48d3221c85f88cca0b5.tar.gz
updated release notes
-rw-r--r--RELEASE24
-rw-r--r--plugins/dbus/abstractdbusinterface.cpp20
2 files changed, 6 insertions, 38 deletions
diff --git a/RELEASE b/RELEASE
index ed611c4e..879f5711 100644
--- a/RELEASE
+++ b/RELEASE
@@ -1,28 +1,8 @@
-Release notes for release 0.11
+Release notes for release 0.12
New features:
-- DBus objects are divided by source and zone (ie /deadbeef23432aaacccbbb/0/VehicleSpeed)
-- new "Zone" DBus property in each interface
-- Get{PropertyName}() DBus method returns extended data about the property.
-- new ZonesForProperty and FindPropertyForZone methods.
-- new FindObject DBus method replaces findProperty
-- OpenCV plugin has experimental CUDA support
-- new "bluemonkey" plugin - a AMB -> javascript gateway
-- new --warning and --error (-w and -e) command line arguments to ambd.
- These new arguments are useful for developers who want error and warning-
- free log output.
-
Changes:
-- findProperty DBus method on org.automotive.Manager is deprecated.
-- Several Properties were changed from Map types to basic types to take
- advantage of zones:
--- Defrost, AirbagStatus, WindowStatus, WindowLockStatus, DistanceSensor,
--- OccupantStatus, SeatBeltStatus, and probably a few more.
-- DBus API: Defrost was moved to the org.automotive.WindowStatus interface
-
+- Deprecated and removed the "FooChanged" (where "Foo" is a property like "VehicleSpeed") signal
Fixes:
-- DBus API: property sigantures was sometimes being reported incorrectly.
- These are now generated dynamically from the GVariant type.
-- BasicPropertyTypes were being generated by the macro without name filled in.
diff --git a/plugins/dbus/abstractdbusinterface.cpp b/plugins/dbus/abstractdbusinterface.cpp
index e2a42b6d..4c0f7a0c 100644
--- a/plugins/dbus/abstractdbusinterface.cpp
+++ b/plugins/dbus/abstractdbusinterface.cpp
@@ -330,16 +330,6 @@ void AbstractDBusInterface::updateValue(AbstractProperty *property)
GError *error = NULL;
GVariant* val = g_variant_ref(property->toGVariant());
- /// TODO deprecate this. there's no need for two signals to be sent
- g_dbus_connection_emit_signal(mConnection, NULL, mObjectPath.c_str(), mInterfaceName.c_str(), string(property->name() + "Changed").c_str(),
- g_variant_new("(vd)",val,property->timestamp()), &error);
-
- if(error)
- {
- DebugOut(DebugOut::Error)<<error->message<<endl;
- g_error_free(error);
- }
-
/// Send PropertiesChanged signal
GVariantBuilder builder;
@@ -349,16 +339,14 @@ void AbstractDBusInterface::updateValue(AbstractProperty *property)
g_variant_builder_add(&builder, "{sv}", std::string(property->name() + "Sequence").c_str(), g_variant_new("i", property->sequence()));
g_variant_builder_add(&builder, "{sv}", "Time", g_variant_new("d", mTime) );
- GError *error2 = NULL;
-
g_dbus_connection_emit_signal(mConnection, NULL, mObjectPath.c_str(), "org.freedesktop.DBus.Properties", "PropertiesChanged", g_variant_new("(sa{sv}as)",
mInterfaceName.c_str(),
- &builder, NULL), &error2);
+ &builder, NULL), &error);
- if(error2)
+ if(error)
{
- DebugOut(DebugOut::Error)<<error2->message<<endl;
- g_error_free(error2);
+ DebugOut(DebugOut::Error)<<error->message<<endl;
+ g_error_free(error);
}
g_variant_unref(val);