summaryrefslogtreecommitdiff
path: root/t/tap-diagnostic.sh
diff options
context:
space:
mode:
authorStefano Lattarini <stefano.lattarini@gmail.com>2013-05-22 22:34:12 +0200
committerStefano Lattarini <stefano.lattarini@gmail.com>2013-05-22 23:55:35 +0200
commit20963917dd4c0591f2983bd6a94426361bd53fa5 (patch)
treee90fa316de6c24065f7dd2e004cabbda000c010b /t/tap-diagnostic.sh
parentf2a1ef46193a8d1bccbb9c4b9e92b644bdb83add (diff)
downloadautomake-20963917dd4c0591f2983bd6a94426361bd53fa5.tar.gz
lint: warn against redirected 'run_make' invocations
The testsuite shell function 'run_make()' has the three options -E, -O and -M to perform the various kind of output redirections, so the test scripts should use them instead of redirecting the output "by hand": run_make ARGS >stdout => run_make -O ARGS run_make ARGS >stderr => run_make -E ARGS run_make ARGS >stdout 2>stderr => run_make -O -E ARGS run_make ARGS >output 2>&1 => run_make -M ARGS See the commit message of v1.13.2-13-gc7cfa09, 2013-05-22 (tests: run_make: options to do command redirection) for an explanation of why this is a good idea. It's worth noting that the present patch only introduced a new static maintainer check looking against the undesired idioms, but doesn't yet remove usages of such idioms from the testsuite. That will be done by follow-up patch(es). * syntax-checks.mk (sc_tests_no_run_make_redirect): New check. (syntax_check_rules): List it. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 't/tap-diagnostic.sh')
0 files changed, 0 insertions, 0 deletions