diff options
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-29 00:48:11 +0200 |
|---|---|---|
| committer | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-29 00:48:11 +0200 |
| commit | bf258729df870cf308f9f92e833d75f192d48a2d (patch) | |
| tree | d835872bfd85ec82eb047e2eb4ec3f2c9d6d4731 /t/maken3.sh | |
| parent | e857a8e7e44592e98848177271d1b41710e4fdaa (diff) | |
| download | automake-bf258729df870cf308f9f92e833d75f192d48a2d.tar.gz | |
tests: prefer "test ! -e FILE" to check that a file doesn't exist
Once, for the sake of (at least) Solaris 10 /bin/sh, we had to use
"test ! -f FILE" or "test ! -r FILE" or "test ! -d FILE" instead,
because the that shell's 'test' built-in didn't grok the '-e' option.
Note however that we still can't use "test ! -e" in the Makefile recipes
used in the test cases; that is because those recipes are run with the
shell detected by 'configure', and Autoconf-generated configure scripts
do no guarantee to find or provide a POSIX-compatible shell.
* Several tests: Adjust.
* t/yacc-clean-cxx: Adjust, and remove a couple of useless commands.
* t/parallel-tests-dry-run-2.sh: Adjust, and add invocation to
"make -n" forgotten in previous versions of the test.
* t/txinfo26.sh: Adjust, and don't bother to skip the test when it's
run in a directory whose absolute path contain whitespace: that setup
is not supported anyway.
* t/maken3.sh: Adjust, and fix a typo that could cause a minor false
negative.
* t/test-trs-recover2.sh: Prefer using 'skip_' with a suitable error
message over a bare 'exit 77'.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 't/maken3.sh')
| -rwxr-xr-x | t/maken3.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/t/maken3.sh b/t/maken3.sh index 99e2305bf..6d580eca8 100755 --- a/t/maken3.sh +++ b/t/maken3.sh @@ -152,7 +152,7 @@ check_targets () if $have_dotmake; then grep "stamp-$target$" stdout || exit 1 fi - test ! -f "stamp-$target$" || exit 1 + test ! -e "stamp-$target" || exit 1 ;; esac case $target in @@ -161,7 +161,7 @@ check_targets () if $have_dotmake; then grep "stamp-$target-sub" stdout || exit 1 fi - test ! -f "sub/stamp-$target-sub" || exit 1 + test ! -e "sub/stamp-$target-sub" || exit 1 ;; esac case $target in @@ -170,7 +170,7 @@ check_targets () if $have_dotmake; then grep "should-not-be-executed" stdout || exit 1 fi - test ! -f "sub2/sub2-$target-should-not-be-executed" || exit 1 + test ! -e "sub2/sub2-$target-should-not-be-executed" || exit 1 ;; esac done |